Page MenuHomePhabricator

VE educational popup should try/catch localStorage calls
Closed, ResolvedPublic1 Estimate Story Points


I configured my Chrome preferences to not accept any sort of local storage and discovered that one of the tools makes calls on localStorage, without try/catch guarding.

Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at VeUiMwLinkInspectorTool.VeUiMwEducationPopupTool


Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterEducation popup: Put localStorage check inside try/catch

Event Timeline

TheDJ created this task.Sep 20 2016, 12:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2016, 12:07 PM
Jdforrester-WMF triaged this task as Medium priority.Sep 20 2016, 6:29 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.

Change 311834 had a related patch set uploaded (by Alex Monk):
Education popup: Put localStorage check inside try/catch

Jdforrester-WMF closed this task as Resolved.Sep 20 2016, 9:03 PM
Jdforrester-WMF assigned this task to AlexMonk-WMF.
Jdforrester-WMF removed a project: Patch-For-Review.

Change 311834 merged by jenkins-bot:
Education popup: Put localStorage check inside try/catch