Page MenuHomePhabricator
Create Task
Maniphest T147659

Warning dialog ("We recommend that you properly fill in all the fields.") is displayed even if there are no warnings in the form
Closed, ResolvedPublic
Actions

Description

Warning dialog ("We recommend that you properly fill in all the fields.") is displayed even if there are no warnings in the form.

pasted_file (943×1 px, 159 KB)

The publishing starts and completes "in the background". It doesn't seem to matter what you click.

Details

SubjectRepoBranchLines +/-
Don't show warning confirmation dialog when there are no warningsmediawiki/extensions/UploadWizardwmf/1.28.0-wmf.21+1 -1
Don't show warning confirmation dialog when there are no warningsmediawiki/extensions/UploadWizardmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Oct 7 2016, 6:09 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptOct 7 2016, 6:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex assigned this task to matthiasmullie.Oct 7 2016, 6:14 PM
matmarex triaged this task as High priority.

This is probably a regression from f5349bb9ec9a294636a4820fa69f1b544ef8ae0e, and live on the wikis already (I just got it when uploading https://test.wikipedia.org/wiki/File:Test_2016-10-07.png). Whoops…

Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 7 2016, 6:14 PM
gerritbot subscribed.Oct 10 2016, 11:32 AM

Change 315072 had a related patch set uploaded (by Matthias Mullie):
Don't show warning confirmation dialog when there are no warnings

https://gerrit.wikimedia.org/r/315072

gerritbot added a project: Patch-For-Review.Oct 10 2016, 11:32 AM
matthiasmullie moved this task from Untriaged to Needs code review on the Multimedia board.Oct 10 2016, 1:09 PM
gerritbot added a comment.Oct 10 2016, 2:35 PM

Change 315096 had a related patch set uploaded (by Bartosz Dziewoński):
Don't show warning confirmation dialog when there are no warnings

https://gerrit.wikimedia.org/r/315096

gerritbot added a comment.Oct 10 2016, 2:41 PM

Change 315096 merged by jenkins-bot:
Don't show warning confirmation dialog when there are no warnings

https://gerrit.wikimedia.org/r/315096

matmarex added a comment.Oct 10 2016, 2:52 PM

Mentioned on Commons' VP: https://commons.wikimedia.org/wiki/Commons:Village_pump#Strange_warning_when_using_the_upload_wizard

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 10 2016, 3:00 PM
gerritbot added a comment.Oct 10 2016, 6:02 PM

Change 315072 merged by jenkins-bot:
Don't show warning confirmation dialog when there are no warnings

https://gerrit.wikimedia.org/r/315072

Stashbot subscribed.Oct 10 2016, 6:29 PM

Mentioned in SAL (#wikimedia-operations) [2016-10-10T18:29:26Z] <dereckson@tin> Synchronized php-1.28.0-wmf.21/extensions/UploadWizard/resources/controller/uw.controller.Details.js: Don't show warning confirmation dialog when there are no warnings (T147659) (duration: 00m 48s)

matmarex closed this task as Resolved.Oct 10 2016, 6:51 PM
matmarex removed a project: Patch-For-Review.

Fixed and deployed.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Oct 10 2016, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits