Page MenuHomePhabricator

Undeletion of missing files is not handled correctly
Closed, DeclinedPublic

Description

Upload a file to the wiki, then delete it. Now remove the backup version of the deleted file from image/deleted/... and then try to restore the deleted file.

You will get something like:

Image:Test.png has been restored
Consult the deletion log for a record of recent deletions and restorations.
Error undeleting file: Could not find file "deleted/0/g/m/0gmrfwcz98nttgzo0f15m7t2kc8wvuk.png".

Also, in the deletion log, an entry is added:

17:15, 24 January 2008 Huji (Talk | contribs | block) restored "Image:Test.png" ‎ (1 revision restored)

Both of these are undesirable. Neither should a "has been restored" be shown, nor should an entry get added to the deletion log.


Version: 1.12.x
Severity: normal

Details

Reference
bz12777

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:03 PM
bzimport set Reference to bz12777.
bzimport added a subscriber: Unknown Object (MLST).

The page text and files are not the same. If the text is restored, that still warrants an entry.