Maniphest T148346

Wikivoyage groups incorrectly show external layers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Yurik
	Oct 16 2016, 9:51 PM

Tags

Referenced Files

	F4635278: Screen Shot 2016-10-20 at 3.59.59 PM.png
	Oct 20 2016, 11:03 PM

	F4612887: Screen Shot 2016-10-17 at 10.45.04 AM.png
	Oct 17 2016, 4:45 PM

Subscribers

Description

https://en.wikivoyage.org/w/index.php?title=Wikivoyage:Travellers%27_pub&oldid=3067391#Maps_with_extra_layers_on_en-Wikivoyage

If you click the layer button, it shows externalData content as the group name

Details

	Subject	Repo	Branch	Lines +/-
	Fix how Wikivoyage shows external groups in the layers dropdown	mediawiki/extensions/Kartographer	master	+28 -5

Customize query in gerrit

Event Timeline

Yurik created this task.Oct 16 2016, 9:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2016, 9:51 PM

Yurik added projects: Maps (Kartographer), Maps, Maps-Sprint.Oct 16 2016, 9:52 PM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptOct 16 2016, 9:52 PM

For clarity - here's a screenshot of what it looks like at https://en.wikivoyage.org/w/index.php?title=Wikivoyage:Travellers%27_pub&oldid=3067391#Maps_with_extra_layers_on_en-Wikivoyage

Screen Shot 2016-10-17 at 10.45.04 AM.png (489×670 px, 169 KB)

Yurik moved this task from Backlog to To-do on the Maps-Sprint board.Oct 17 2016, 8:15 PM

• JGirault moved this task from To-do to In progress on the Maps-Sprint board.Oct 20 2016, 9:59 PM

Change 317076 had a related patch set uploaded (by JGirault):
Fix how Wikivoyage shows external groups in the layers dropdown

https://gerrit.wikimedia.org/r/317076

gerritbot added a project: Patch-For-Review.Oct 20 2016, 11:02 PM

As part of the fix, I did https://github.com/juliengirault/wikimedia-mapdata/pull/4 and merged it.

Here's a screenshot on how Wikivoyage will show external groups:

Screen Shot 2016-10-20 at 3.59.59 PM.png (272×369 px, 30 KB)

• JGirault moved this task from In progress to Needs review on the Maps-Sprint board.Oct 20 2016, 11:04 PM

Change 317076 merged by jenkins-bot:
Fix how Wikivoyage shows external groups in the layers dropdown

https://gerrit.wikimedia.org/r/317076

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 21 2016, 5:00 AM

Yurik closed this task as Resolved.Oct 21 2016, 5:01 AM