Page MenuHomePhabricator

$wgRateLimitsExcludedGroups should be replaced by 'noratelimits' right
Closed, ResolvedPublic


Patch that adds the 'noratelimits' right

I don't really understand why we still have $wgRateLimitsExcludedGroups = array('sysop', 'bureaucrat'); while we could as well have:

$wgGroupPermissions['sysop']['noratelimits'] = true;
$wgGroupPermissions['bureaucrat']['noratelimits'] = true;

Is there some underlying reason I'm missing here, or is it just that no one has thought of this and/or gotten around to implementing this yet?

Version: 1.12.x
Severity: enhancement




Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:02 PM
bzimport set Reference to bz12859.
bzimport added a subscriber: Unknown Object (MLST).

Done in r35794. Input welcome, this being my first commit.

I seem to recall reverting that one, some issues remaining. :)

Fixed in r35908. Got it right this time. ;-)

Kept the old functionality intact, but updated the documentation on it to reflect that it's been deprecated in favor of the new method via $wgGroupPermissions.