Page MenuHomePhabricator

Commons on Upload File page shows "or" without a second option
Closed, DuplicatePublic

Description

On the Upload File page on Commons, there is an "Or" text below the Select media file to share button and below, there is an "Or" text which I thought below will be an alternative way to share the media files but I didn't find anything below the "Or".

I am using a Mac Book Pro 13" and running Mac OS X El Capitan with a Google Chrome browser? Is the "Or" text written there intentionally with no text or option or button below it or is this a bug? Below is a snap shot of this scenario.

Event Timeline

D3r1ck01 created this task.Oct 20 2016, 7:26 PM
Restricted Application added subscribers: Poyekhali, Aklapper. · View Herald TranscriptOct 20 2016, 7:26 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptOct 20 2016, 8:02 PM

Change 317013 had a related patch set uploaded (by Paladox):
Fix a weird ghost "or" for non-Flickr users

https://gerrit.wikimedia.org/r/317013

Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 20 2016, 8:03 PM

@Paladox, So it has been fixed but changes have not been deployed yet?

@D3r1ck01 yes looks like it.

@Paladox, thanks for closing the task and marking it as duplicate. Hoping to see the changes deployed :)

Ok, it's been added to deployments for tonight :).

Change 317013 merged by jenkins-bot:
Fix a weird ghost "or" for non-Flickr users

https://gerrit.wikimedia.org/r/317013

Aklapper renamed this task from Commons bug on Upload File page to Commons on Upload File page shows "or" without a second option.Oct 20 2016, 11:26 PM
Gilles added a subscriber: Gilles.EditedOct 27 2016, 8:14 AM

I'm only going to be "that guy" on this task because I just can't pass on the irony of only having to go back a few days in the UploadWizard phabricator feed to find this perfect example, but I'm sure I would find more if I dug further.

This comment on the changeset commit message just about sums it up:

"missed in the tests because I usually have that option turned on..."

This regression bug is the poster child of the consequences of abandoning a very complete set of browser tests. One small bug at a time, you're perpetuating the feeling that the software is buggy to users. And you will keep missing things like this because there's only so much you're going to cover by testing manually, with your own settings. The browser tests that have been deleted had coverage for testing with and without flickr upload rights.

See T94161 for context about why I bring this up.

I think your comment is very unfair and mostly untrue. I replied further on T94161.