Here Diannaa is listed as having the "Max. text added", that's because she revdel'd a series of edits, and xtools compared the last visible diff with the first live diff after it, which is this. She in fact did not add any content, see the revision history. If there's some way to tell that revisions have been revdel'd, we should not take into account the surrounding diffs. I'm guessing the revdel'd edits are not in the revision table, even though it's only the content (and not the author, edit summary, etc) that's been scrubbed from view.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Matthewrbowker | T153112 Epic: Rewriting XTools | |||
| Resolved | MusikAnimal | T157602 [Epic] Rewrite XTools: Articleinfo | |||
| Resolved | MusikAnimal | T148857 If revisions are revdel'd, articleinfo compares the surrounding edits as if it were one edit |
Event Timeline
Comment Actions
Done with https://github.com/x-tools/xtools-rebirth/commit/ae26583752ecd450107eaa73cc45421039e3fd36
The real issue is that rev_len is not being replicated, even though the diff sizes of revdel'd edits are visible in production. See T101631 for more.
As a workaround, all we're doing here is checking if the previous revision has a rev_len of null, and if so, treat target revision as having a diff size of 0. This means if User:Foo made two edits but only the first one was revdel'd, the second still has a diff size of 0 even though it actually made a change. Until T101631 is resolved I don't see a way around this.
Comment Actions
Deployed to xtools-dev https://tools.wmflabs.org/xtools-dev/articleinfo/en.wikipedia.org/Alpha-tubulin_N-acetyltransferase
Diannaa is not longer listed as having the "Max. text added"
Comment Actions
Code looks reasonable. Haven't been able to test since XTool-dev has been down all day :(