Page MenuHomePhabricator

Kartographer no longer displays external data credits
Closed, ResolvedPublic

Description

The recent geomask service introduced a little regression in the code, resulting in group attributions being ignored.

The issue is located at https://github.com/nyurik/wikimedia-mapdata/commit/131284194cda7a00b36e6b22cb90e519cbf38a29#diff-3143c0ec6f660badf4d52ad8bc373a6eR104 where service is removed from the GeoJSON data.
parseAttributions relies on it so it's become no-op.

Details

Related Gerrit Patches:
mediawiki/extensions/Kartographer : wmf/1.28.0-wmf.23Fix external links
mediawiki/extensions/Kartographer : masterFix external links

Event Timeline

Restricted Application added a project: Discovery. · View Herald TranscriptOct 26 2016, 12:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Yurik triaged this task as High priority.Oct 26 2016, 2:41 AM
Yurik added a subscriber: Yurik.

Oops, sorry Julien. I will revert it shortly.

Yurik claimed this task.Oct 26 2016, 2:47 AM

Change 318039 had a related patch set uploaded (by Yurik):
Fix external links

https://gerrit.wikimedia.org/r/318039

Change 318039 merged by jenkins-bot:
Fix external links

https://gerrit.wikimedia.org/r/318039

Change 318040 had a related patch set uploaded (by Yurik):
Fix external links

https://gerrit.wikimedia.org/r/318040

Yurik closed this task as Resolved.Oct 26 2016, 4:30 AM

Change 318040 merged by jenkins-bot:
Fix external links

https://gerrit.wikimedia.org/r/318040

Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2016-10-26T13:23:33Z] <hashar@tin> Synchronized php-1.28.0-wmf.23/extensions/Kartographer: T149145: Fix empty groups params T149154: Fix external links (duration: 00m 57s)