Page MenuHomePhabricator
Create Task
Maniphest T149154

Kartographer no longer displays external data credits
Closed, ResolvedPublic
Actions

Description

The recent geomask service introduced a little regression in the code, resulting in group attributions being ignored.

The issue is located at https://github.com/nyurik/wikimedia-mapdata/commit/131284194cda7a00b36e6b22cb90e519cbf38a29#diff-3143c0ec6f660badf4d52ad8bc373a6eR104 where service is removed from the GeoJSON data.
parseAttributions relies on it so it's become no-op.

Details

SubjectRepoBranchLines +/-
Fix external linksmediawiki/extensions/Kartographerwmf/1.28.0-wmf.23+0 -3
Fix external linksmediawiki/extensions/Kartographermaster+0 -3
Customize query in gerrit

Related Objects

Event Timeline

• JGirault created this task.Oct 26 2016, 12:54 AM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptOct 26 2016, 12:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Yurik triaged this task as High priority.Oct 26 2016, 2:41 AM
Yurik subscribed.

Oops, sorry Julien. I will revert it shortly.

Yurik claimed this task.Oct 26 2016, 2:47 AM
gerritbot subscribed.Oct 26 2016, 4:22 AM

Change 318039 had a related patch set uploaded (by Yurik):
Fix external links

https://gerrit.wikimedia.org/r/318039

gerritbot added a project: Patch-For-Review.Oct 26 2016, 4:22 AM
gerritbot added a comment.Oct 26 2016, 4:28 AM

Change 318039 merged by jenkins-bot:
Fix external links

https://gerrit.wikimedia.org/r/318039

gerritbot added a comment.Oct 26 2016, 4:28 AM

Change 318040 had a related patch set uploaded (by Yurik):
Fix external links

https://gerrit.wikimedia.org/r/318040

Yurik closed this task as Resolved.Oct 26 2016, 4:30 AM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Oct 26 2016, 5:00 AM
gerritbot added a comment.Oct 26 2016, 1:14 PM

Change 318040 merged by jenkins-bot:
Fix external links

https://gerrit.wikimedia.org/r/318040

Stashbot mentioned this in T149145: Snapshot service not working with empty groups param.Oct 26 2016, 1:23 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2016-10-26T13:23:33Z] <hashar@tin> Synchronized php-1.28.0-wmf.23/extensions/Kartographer: T149145: Fix empty groups params T149154: Fix external links (duration: 00m 57s)

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 26 2016, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits