I can help with that. Is the function mw.Map#values in many files or the one you pointed only ?

According to this search it is also in mw.flow.ui.VisualEditorWidget.js

Thanks, I have already made the commit but jenkins is complaining for a non existing test error

I made a gerrit review but jenkins is complaining about a non existent problem in a different file from those I edited

https://gerrit.wikimedia.org/r/#/c/318793

I search around the web and I found out that jhint expect all the functions that start with an uppercase to be object constructors and it displays an error that the function is not initialized with the 'new' keyword
for more information

http://stackoverflow.com/questions/10668111/jshint-expects-the-new-prefix-for-functions

https://integration.wikimedia.org/ci/job/jshint/6340/console linked from https://gerrit.wikimedia.org/r/#/c/318793 says:

modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js: line 203, col 48, Missing 'new' prefix when invoking a constructor.

That indeed is far away from code that you touched in your patch. :(

In T149304#2761690, @Aklapper wrote:

https://integration.wikimedia.org/ci/job/jshint/6340/console linked from https://gerrit.wikimedia.org/r/#/c/318793 says:

modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js: line 203, col 48, Missing 'new' prefix when invoking a constructor.

That indeed is far away from code that you touched in your patch. :(

I worked around this in a separate patch. I'll rebase your patch onto that.