Page MenuHomePhabricator

Polestar builder does not work in Firefox
Closed, ResolvedPublic

Description

Polestar builder does not work in Firefox. Produces this error:

Error: wikidatasparql: missing query parameter in: wikidatasparql://query.wikidata.org/?query=#How many musicians dies at certain age%0A#added before 2016-10%0A%0A   # Query to find all musicians who have already died %0A   # calculate their age (full years) at death%0A   # count how many of them died at each age%0A%0A    SELECT ?age  (COUNT (DISTINCT ?a) AS ?count) WHERE {%0A        ?a wdt:P31 wd:Q5 . #instance of human%0A        ?a wdt:P106/wdt:P279 wd:Q639669 . #occupation a subclass of musician%0A        ?a p:P569/psv:P569 ?birth_date_node . %0A        ?a p:P570/psv:P570 ?death_date_node .%0A        ?birth_date_node wikibase:timeValue ?birth_date .%0A        ?death_date_node wikibase:timeValue ?death_date .%0A        FILTER(?age > 10 && ?age < 100) . #ignore outlyers, several of which are probably errors%0A        BIND( year(?death_date) - year(?birth_date) - if(month(?death_date)<month(?birth_date) || (month(?death_date)=month(?birth_date) && day(?death_date)<day(?birth_date)),1,0) as ?age )%0A        # calculate the age, precisely to the day (times and timezones ignored)%0A    } %0A%09GROUP BY ?age%0A    ORDER BY ?age
Stack trace:
[3]</i.prototype.sanitizeUrl@https://query.wikidata.org/polestar/scripts/vendor.js:321:21683
i/e.load.loader@https://query.wikidata.org/polestar/scripts/vendor.js:321:18666
r@https://query.wikidata.org/polestar/scripts/vendor.js:271:27391
t.getUpdate/<@https://query.wikidata.org/polestar/scripts/app.js:32:1012
xn/E@https://query.wikidata.org/polestar/scripts/vendor.js:173:7046
t.getUpdate@https://query.wikidata.org/polestar/scripts/app.js:32:996
h.update@https://query.wikidata.org/polestar/scripts/vendor.js:320:12277
@https://query.wikidata.org/polestar/scripts/app.js:32:7012
a@https://query.wikidata.org/polestar/scripts/vendor.js:171:20798
_t/this.$get</</g<@https://query.wikidata.org/polestar/scripts/vendor.js:172:14796
d@https://query.wikidata.org/polestar/scripts/vendor.js:172:1725
a@https://query.wikidata.org/polestar/scripts/vendor.js:171:30357
U/<@https://query.wikidata.org/polestar/scripts/vendor.js:171:29888
ma</<.link@https://query.wikidata.org/polestar/scripts/vendor.js:175:19579
B/<@https://query.wikidata.org/polestar/scripts/vendor.js:171:5649
ve@https://query.wikidata.org/polestar/scripts/vendor.js:172:10052
d@https://query.wikidata.org/polestar/scripts/vendor.js:172:2501
a@https://query.wikidata.org/polestar/scripts/vendor.js:171:30357
U/<@https://query.wikidata.org/polestar/scripts/vendor.js:171:29888
Z/<@https://query.wikidata.org/polestar/scripts/vendor.js:172:528
i@https://query.wikidata.org/polestar/scripts/vendor.js:171:30851
h@https://query.wikidata.org/polestar/scripts/vendor.js:172:972
ga</<.compile/</</<@https://query.wikidata.org/polestar/scripts/vendor.js:175:19058
a@https://query.wikidata.org/polestar/scripts/vendor.js:173:4592
s/<@https://query.wikidata.org/polestar/scripts/vendor.js:173:4764
Tn/this.$get</p.prototype.$eval@https://query.wikidata.org/polestar/scripts/vendor.js:173:12405
Tn/this.$get</p.prototype.$digest@https://query.wikidata.org/polestar/scripts/vendor.js:173:10887
Tn/this.$get</p.prototype.$apply@https://query.wikidata.org/polestar/scripts/vendor.js:173:12690
re/a/<@https://query.wikidata.org/polestar/scripts/vendor.js:171:8176
a@https://query.wikidata.org/polestar/scripts/vendor.js:171:20798
re/a@https://query.wikidata.org/polestar/scripts/vendor.js:171:8097
re@https://query.wikidata.org/polestar/scripts/vendor.js:171:8383
ie@https://query.wikidata.org/polestar/scripts/vendor.js:171:7622
@https://query.wikidata.org/polestar/scripts/vendor.js:176:8298
o/</f@https://query.wikidata.org/polestar/scripts/vendor.js:25:24830
o/</h<@https://query.wikidata.org/polestar/scripts/vendor.js:25:25147

Looks like something works differently in FF...

Event Timeline

@Smalyshev could you add repo steps so that I can post this bug to the vega forum?

Well, go to query.wikidata.org, I think pretty much any query should do but I used the musicians dead by age one, then click on "graph builder".

Change 319496 had a related patch set uploaded (by Smalyshev):
Fix polestar view in Firefox.

https://gerrit.wikimedia.org/r/319496

Change 319496 merged by jenkins-bot:
Fix polestar view in Firefox.

https://gerrit.wikimedia.org/r/319496

thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde subscribed.

The patch https://gerrit.wikimedia.org/r/319496 utilizes atob and btoa. It looks like these functions are disputed, and according to https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64 they do not exist in IE9. Do we have a compatibility layer in place for this?

Change 320420 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace problematic atob/btoa with encode/decodeURIComponent

https://gerrit.wikimedia.org/r/320420

Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-11-08 board.

Change 320420 merged by jenkins-bot:
Replace problematic atob/btoa with encode/decodeURIComponent

https://gerrit.wikimedia.org/r/320420