Snapshot container inherits font size from parent
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JGirault
	Nov 2 2016, 11:03 PM

Description

Leaflet/mapbox.js fixes the font size to 12px - which should be changed to 14px to align with article contents font size.

Snapshot container does not rely on leaflet, so inherits font size from parent. When it's put within a parent container that sets a smaller font size, the OOjs UI control for opening the map full screen is rendered with incorrect padding.

See screenshot:

Screen Shot 2016-11-02 at 4.02.53 PM.png (320×313 px, 12 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Sets font size to 14px for both static and interactive maps	mediawiki/extensions/Kartographer	wmf/1.29.0-wmf.1	+4 -1
	Sets font size to 14px for both static and interactive maps	mediawiki/extensions/Kartographer	master	+4 -1

Customize query in gerrit

Event Timeline

• JGirault created this task.Nov 2 2016, 11:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2016, 11:03 PM

Change 319488 had a related patch set uploaded (by JGirault):
Sets font size to 14px for both static and interactive maps

https://gerrit.wikimedia.org/r/319488

gerritbot added a project: Patch-For-Review.Nov 2 2016, 11:04 PM

• JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.Nov 2 2016, 11:04 PM

After the patch, the map looks like:

Screen Shot 2016-11-02 at 4.05.54 PM.png (318×314 px, 12 KB)

As a result of this patch, the popup text will be a little bigger: increased to`14px`, the same size as the article contents.

Before: 12px	After: 14px

Change 319493 had a related patch set uploaded (by Yurik):
Sets font size to 14px for both static and interactive maps

https://gerrit.wikimedia.org/r/319493

Change 319488 merged by jenkins-bot:
Sets font size to 14px for both static and interactive maps

https://gerrit.wikimedia.org/r/319488

Dereckson triaged this task as High priority.Nov 2 2016, 11:22 PM

Change 319493 merged by jenkins-bot:
Sets font size to 14px for both static and interactive maps

https://gerrit.wikimedia.org/r/319493

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)), MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Nov 3 2016, 12:00 AM

Mentioned in SAL (#wikimedia-operations) [2016-11-03T00:23:57Z] <dereckson@tin> Synchronized php-1.29.0-wmf.1/extensions/Kartographer/styles/: Set font size to 14px for both static and interactive maps (T149860) (duration: 00m 47s)

Thanks!!!

• Deskana moved this task from Needs review to Done on the Maps-Sprint board.Apr 19 2017, 4:29 PM

	F4690616: Screen Shot 2016-11-02 at 4.09.48 PM.png
	Nov 2 2016, 11:11 PM

	F4690618: Screen Shot 2016-11-02 at 4.09.41 PM.png
	Nov 2 2016, 11:11 PM

	F4690608: Screen Shot 2016-11-02 at 4.05.54 PM.png
	Nov 2 2016, 11:07 PM

	F4690594: Screen Shot 2016-11-02 at 4.02.53 PM.png
	Nov 2 2016, 11:03 PM

Snapshot container inherits font size from parentClosed, ResolvedPublicActions

Description

Details

Event Timeline

Snapshot container inherits font size from parent
Closed, ResolvedPublic
Actions