Page MenuHomePhabricator
Create Task
Maniphest T150161

Extend quantity value browsertests (unit & precision)
Closed, ResolvedPublic
Actions

Description

We should extend the browsertests for the quantity datatype. Unit support got added and handling of precision changed, so we should at least add a scenario for testing units and adjust existing scenarios to check for correct precision handling.

Details

SubjectRepoBranchLines +/-
Check for unitsuggester in browsertestsmediawiki/extensions/Wikibasemaster+6 -0
Customize query in gerrit

Event Timeline

Tobi_WMDE_SW created this task.Nov 7 2016, 10:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2016, 10:15 AM
Tobi_WMDE_SW added projects: WMDE-TechWish, User-Tobi_WMDE_SW.Nov 16 2016, 11:12 AM
Tobi_WMDE_SW moved this task from Proposed to Todo on the WMDE-TechWish board.Nov 16 2016, 11:49 AM
Tobi_WMDE_SW claimed this task.Nov 17 2016, 11:35 AM
Tobi_WMDE_SW moved this task from Todo to Sprint ready on the WMDE-TechWish board.
Tobi_WMDE_SW added a project: Patch-For-Review.Nov 17 2016, 1:51 PM

The precision bit has been tackled in https://gerrit.wikimedia.org/r/#/c/322088/

gerritbot subscribed.Nov 17 2016, 2:39 PM

Change 322104 had a related patch set uploaded (by Tobias Gritschacher):
Check for unitsuggester in browsertests

https://gerrit.wikimedia.org/r/322104

gerritbot added a comment.Nov 17 2016, 4:18 PM

Change 322104 merged by jenkins-bot:
Check for unitsuggester in browsertests

https://gerrit.wikimedia.org/r/322104

Tobi_WMDE_SW moved this task from Sprint ready to Done on the WMDE-TechWish board.Nov 21 2016, 2:09 PM
Tobi_WMDE_SW closed this task as Resolved.Nov 24 2016, 9:49 AM
Tobi_WMDE_SW moved this task from Incoming to Done on the User-Tobi_WMDE_SW board.Jan 11 2017, 2:52 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jan 18 2017, 3:30 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits