Page MenuHomePhabricator
Create Task
Maniphest T150188

Investigate if <translate> new line handling can be improved quickly
Closed, ResolvedPublic
Actions

Description

<translate>foo</translate> becomes

<translate> <!--T:1-->
<translate>

Not having the newline there for inline usage of tags could improve how this interacts with the parser.

Follow-up for Editing offsite discussion.

Details

SubjectRepoBranchLines +/-
PageTranslation: do not add line breaks to inline usage of <translate> tagsmediawiki/extensions/Translatemaster+166 -20
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Nov 7 2016, 4:41 PM
Restricted Application added a project: Language-Engineering October-December 2016. · View Herald TranscriptNov 7 2016, 4:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Arrbee moved this task from Backlog to Translate-maintenance on the Language-Engineering October-December 2016 board.Nov 8 2016, 7:45 AM
gerritbot subscribed.Nov 9 2016, 10:26 AM

Change 320571 had a related patch set uploaded (by Nikerabbit):
PageTranslation: do not add line breaks to inline usage of <translate> tags

https://gerrit.wikimedia.org/r/320571

gerritbot added a project: Patch-For-Review.Nov 9 2016, 10:26 AM
Nikerabbit moved this task from Backlog to In Review on the Language-Q2-2016-17 Sprint 3 board.Nov 9 2016, 10:40 AM

Time spent so far: ~2 hours

Arrbee triaged this task as Medium priority.Nov 10 2016, 8:15 AM
gerritbot added a comment.Nov 23 2016, 11:13 AM

Change 320571 merged by Nikerabbit:
PageTranslation: do not add line breaks to inline usage of <translate> tags

https://gerrit.wikimedia.org/r/320571

Nikerabbit removed a project: Patch-For-Review.Nov 23 2016, 12:30 PM
Nikerabbit moved this task from In Review to Done on the Language-Q2-2016-17 Sprint 3 board.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 28 2016, 12:01 AM
Amire80 closed this task as Resolved.Dec 5 2016, 6:28 PM
Amire80 claimed this task.
Amire80 subscribed.

Verified.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits