Maniphest T150791

Blocked users cannot use Special:CiteThisPage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Orlodrim
	Nov 15 2016, 7:10 PM

Tags

Referenced Files

None

Subscribers

View All 9 Subscribers

Tokens

"Like" token, awarded by OldUser02."Like" token, awarded by Thibaut120094.

Description

Navigating to Special:CiteThisPage shows an error page for blocked users/IPs whose title is "User is blocked" (blockedtitle). This is unexpected, because blocked users should be able to use the tool to cite pages.

This issue has been reported on https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Questions_techniques/semaine_46_2016#Blocage_et_.22Citer_cette_page.22, and I was able to reproduce it on fr.wikipedia.org by using a globally blocked IP.

I believe this is related to the change https://gerrit.wikimedia.org/r/313557, which was done to solve T147046: as far as I understand, FormSpecialPage does not allow blocked users to run execute() unless requiresUnblock is overridden.

Details

	Subject	Repo	Branch	Lines +/-
	Allow blocked users to use Special:CiteThisPage	mediawiki/extensions/CiteThisPage	REL1_28	+4 -0
	Allow blocked users to use Special:CiteThisPage	mediawiki/extensions/CiteThisPage	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned Here: T147046: Convert Special:CiteThisPage to OOUI

Event Timeline

Orlodrim created this task.Nov 15 2016, 7:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2016, 7:10 PM

Change 321710 had a related patch set uploaded (by Legoktm):
Allow blocked users to use Special:CiteThisPage

https://gerrit.wikimedia.org/r/321710

gerritbot added a project: Patch-For-Review.Nov 15 2016, 7:35 PM

My bad, thanks for filing a bug.

And the patch causing this is in REL1_28, so we should backport this.

Change 321710 merged by jenkins-bot:
Allow blocked users to use Special:CiteThisPage

https://gerrit.wikimedia.org/r/321710

Change 321723 had a related patch set uploaded (by Legoktm):
Allow blocked users to use Special:CiteThisPage

https://gerrit.wikimedia.org/r/321723

Legoktm closed this task as Resolved.Nov 15 2016, 8:35 PM

Change 321723 merged by jenkins-bot:
Allow blocked users to use Special:CiteThisPage

https://gerrit.wikimedia.org/r/321723

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 15 2016, 9:00 PM

Thibaut120094 awarded a token.Nov 17 2016, 9:19 AM

Thibaut120094 rescinded a token.

Thibaut120094 awarded a token.

Thibaut120094 subscribed.

• OldUser02 awarded a token.Nov 17 2016, 9:32 AM

• OldUser02 subscribed.

Trizek-WMF subscribed.Nov 17 2016, 2:19 PM

Framawiki subscribed.Nov 17 2016, 6:03 PM