Page MenuHomePhabricator

Height of images in slideshow is not changing.
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps:

  1. Open VisualEditor
  2. Click Insert
  3. From the drop down menu click more
  4. Click on Gallery
  5. In the search box type “car”
  6. Click on Options
  7. From the drop menu of Display mode select Slideshow
  8. Change the image height to 20px.
  9. Select a couple of car images which will be part of the slideshow.
  10. Click Done

Expected Output: The read mode should display a slideshow with a 20px height of the images.

Observation : The height of images does seem to be of 20px. when in the edit mode but after saving the edit it is not 20px in read mode.

Edit Mode Screenshot:


Read Mode Screenshot:

Browser Used: Google Chrome 54.0.2840.99 m
OS: Windows 10
Environment: Test2

Event Timeline

There is a slightly complicated reason for this...

The gallery tag's height attribute doesn't have an effect in slideshow mode: https://en.wikipedia.org/wiki/Help:Gallery_tag#Attributes_and_values

In edit mode, slideshow galleries are not displayed as slideshows (see T151471), so when the height attribute changes the new heights are actually displayed; however, in read mode slideshow galleries are rendered as slideshows, at which point the height is ignored.

It would be less confusing if the gallery dialog disabled height, width, etc in the modes that they don't apply to.

Change 325102 had a related patch set uploaded (by Tchanders):
Disable heights option in gallery dialog when mode is slideshow

https://gerrit.wikimedia.org/r/325102

Jdforrester-WMF assigned this task to Tchanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

Change 325102 merged by jenkins-bot:
Disable heights option in gallery dialog when mode is slideshow

https://gerrit.wikimedia.org/r/325102