Page MenuHomePhabricator
Create Task
Maniphest T151594

"Uncaught Error: Inserted data is trying to close the root node (at index 0)" while trying to go to next line after adding an empty heading
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open VE
  2. For Paragraph style, choose Sub-Heading 1 or any other option from that list
  3. Now press enter without typing something

Observed Result:
There is an error in the console: Uncaught Error: Inserted data is trying to close the root node (at index 0)

Screen Shot 2016-11-24 at 4.47.14 PM.png (651×1 px, 189 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (1934b77e7)mediawiki/extensions/VisualEditormaster+1 -1
ui.FormatAction: fixup selection for empty conversionsVisualEditor/VisualEditormaster+24 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Nov 25 2016, 12:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2016, 12:47 AM
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.Nov 29 2016, 8:18 PM
Jdforrester-WMF renamed this task from Uncaught Error: Inserted data is trying to close the root node (at index 0)while trying to go to next line after adding an empty heading to "Uncaught Error: Inserted data is trying to close the root node (at index 0)" while trying to go to next line after adding an empty heading.Dec 6 2016, 5:35 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
Jdforrester-WMF set the point value for this task to 8.
gerritbot subscribed.Jun 29 2017, 4:08 PM

Change 362229 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] ui.FormatAction: fixup selection for empty conversions

https://gerrit.wikimedia.org/r/362229

gerritbot added a project: Patch-For-Review.Jun 29 2017, 4:08 PM
gerritbot added a comment.Jul 3 2017, 10:05 PM

Change 362229 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ui.FormatAction: fixup selection for empty conversions

https://gerrit.wikimedia.org/r/362229

gerritbot added a comment.Jul 6 2017, 8:41 PM

Change 363691 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1934b77e7)

https://gerrit.wikimedia.org/r/363691

gerritbot added a comment.Jul 6 2017, 9:07 PM

Change 363691 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1934b77e7)

https://gerrit.wikimedia.org/r/363691

Jdforrester-WMF closed this task as Resolved.Jul 6 2017, 9:09 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 6 2017, 9:09 PM
Ryasmeen added a project: Verified.Jul 7 2017, 12:18 AM
Ryasmeen added a project: Verified-in-Phase0.Jul 12 2017, 1:40 AM
DLynch mentioned this in T146958: On blank lines, you can select multiple formats from the format menu; the surface only responds to the first, until there is cotent.Sep 26 2017, 4:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL