Page MenuHomePhabricator
Create Task
Maniphest T153000

Skip 'descriptionpage' step of test tour (test.js) if there is no description page, and 'launchtour' step if it's not editable and main namespace
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Handle Help:Guided tour/guider not existing, not being able to launchmediawiki/extensions/GuidedTourREL1_28+92 -60
Handle Help:Guided tour/guider not existing, not being able to launchmediawiki/extensions/GuidedTourmaster+92 -60
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mattflaschen-WMF created this task.Dec 12 2016, 7:40 PM
• Mattflaschen-WMF renamed this task from Skip 'descriptionpage' step of test tour (test.js) if there is no description page to Skip 'descriptionpage' step of test tour (test.js) if there is no description page, and launchtour step if it's not editable and main namespace.Dec 12 2016, 7:48 PM
• Mattflaschen-WMF renamed this task from Skip 'descriptionpage' step of test tour (test.js) if there is no description page, and launchtour step if it's not editable and main namespace to Skip 'descriptionpage' step of test tour (test.js) if there is no description page, and 'launchtour' step if it's not editable and main namespace.
• Mattflaschen-WMF claimed this task.
gerritbot subscribed.Dec 13 2016, 11:29 PM

Change 327128 had a related patch set uploaded (by Mattflaschen):
Handle Help:Guided tour/guider not existing, not being able to launch

https://gerrit.wikimedia.org/r/327128

gerritbot added a project: Patch-For-Review.Dec 13 2016, 11:29 PM
Dereckson moved this task from Backlog to Working on on the Wikimedia-Site-requests board.Dec 15 2016, 12:55 AM
Dereckson mentioned this in T152827: Enable GuidedTour on all wikis.Feb 13 2017, 9:54 PM
gerritbot added a comment.Feb 22 2017, 12:58 PM

Change 327128 merged by jenkins-bot:
Handle Help:Guided tour/guider not existing, not being able to launch

https://gerrit.wikimedia.org/r/327128

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)).Feb 22 2017, 1:00 PM
• Mattflaschen-WMF added a project: Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017).Feb 22 2017, 7:53 PM
• Mattflaschen-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Etonkovidova added subscribers: • jmatazzoni, Etonkovidova.Feb 23 2017, 9:40 PM

Checked in betalabs - guided tours work as expected per the fix

@jmatazzoni - if you are curios, you may see the demo of a full-length guided tour at https://en.wikipedia.org/wiki/Wikipedia:Sandbox?tour=test.

QA recommendation: Resolve.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Feb 23 2017, 9:43 PM
• jmatazzoni closed this task as Resolved.Feb 23 2017, 10:32 PM
gerritbot added a comment.Jun 6 2017, 7:27 PM

Change 357443 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/GuidedTour@REL1_28] Handle Help:Guided tour/guider not existing, not being able to launch

https://gerrit.wikimedia.org/r/357443

gerritbot added a comment.Oct 2 2017, 2:04 PM

Change 357443 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@REL1_28] Handle Help:Guided tour/guider not existing, not being able to launch

https://gerrit.wikimedia.org/r/357443

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits