Page MenuHomePhabricator

Adding a new line in the caption for an image in Gallery creates a blank image space, makes Gallery inaccessible after insertion
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce;

  1. Open Gallery dialog
  2. Select an image
  3. In the caption field type something and press return to go to next line and type something more on the second line
  4. Insert it

Observed Result:
a. It creates a second blank image space with the caption from second line.
b. Clicking on Edit again does not open Gallery anymore,
c. Insert>Gallery also does not work to anymore until that Gallery is removed.

Screen Shot 2016-12-15 at 2.29.11 PM.png (304×680 px, 43 KB)

Event Timeline

Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

We should fail better. :-)

Change 342242 had a related patch set uploaded (by Tchanders):
[mediawiki/extensions/VisualEditor] Remove line breaks from gallery dialog captions

https://gerrit.wikimedia.org/r/342242

Change 342242 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Remove line breaks from gallery dialog captions

https://gerrit.wikimedia.org/r/342242