validateRegistrationFile.php: Check for duplicate key in json
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Dec 16 2016, 11:57 PM

Description

Some extension.json (or skin.json) have duplicate keys inside, which makes it hard to read with external json readers and may is an error in the file, because it is not save, which key "wins"

There should be a validation check to avoid duplicate keys in registration files.

examples:
https://gerrit.wikimedia.org/r/#/c/327869/
https://gerrit.wikimedia.org/r/#/c/327870/
https://gerrit.wikimedia.org/r/#/c/327871/
https://gerrit.wikimedia.org/r/#/c/327874/
https://gerrit.wikimedia.org/r/#/c/327875/
https://gerrit.wikimedia.org/r/#/c/327876/

Details

Subject	Repo	Branch	Lines +/-
registration: Validate no duplicate keys exist in extension.json	mediawiki/core	REL1_29	+15 -2
registration: Validate no duplicate keys exist in extension.json	mediawiki/core	REL1_30	+15 -2
registration: Validate no duplicate keys exist in extension.json	mediawiki/core	master	+23 -2

Customize query in gerrit

Related Objects

Mentioned Here: T73284: Augment jsonlint test with a test for duplicate keys

Event Timeline

Umherirrender created this task.Dec 16 2016, 11:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2016, 11:57 PM

I think we can probably use https://github.com/Seldaek/jsonlint for this.

It would be nice, if it is not entry point related, because there are also i18n json files with duplicate keys

Or decline as the mention task (or set duplicate), if this is not taken as a problem - In my opinion this can indicate errors inside the files and should be detected

Florian claimed this task.Jan 22 2017, 3:18 PM

Example output:

florian@florian-VirtualBox:/var/www/html/mediawiki/w$ phph maintenance/validateRegistrationFile.php extensions/GoogleLogin/extension.json (without duplicate key)
extensions/GoogleLogin/extension.json validates against the schema!
florian@florian-VirtualBox:/var/www/html/mediawiki/w$ phph maintenance/validateRegistrationFile.php extensions/GoogleLogin/extension.json (with duplicate key)
Parse error on line 155:
...er_autoloader": true,	"manifest_version
----------------------^
Duplicate key: load_composer_autoloader

Change 333502 had a related patch set uploaded (by Florianschmidtwelzow):
Add key conflict check to extension.json validation

https://gerrit.wikimedia.org/r/333502

gerritbot added a project: Patch-For-Review.Jan 22 2017, 3:38 PM

Ricordisamoa subscribed.Feb 27 2017, 11:55 PM

Change 333502 merged by jenkins-bot:
[mediawiki/core@master] registration: Validate no duplicate keys exist in extension.json

https://gerrit.wikimedia.org/r/333502

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 18 2018, 10:00 AM

Legoktm closed this task as Resolved.Jul 18 2018, 10:01 AM

Change 446573 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/core@REL1_30] registration: Validate no duplicate keys exist in extension.json

https://gerrit.wikimedia.org/r/446573

Change 446574 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/core@REL1_29] registration: Validate no duplicate keys exist in extension.json

https://gerrit.wikimedia.org/r/446574

Change 446573 merged by jenkins-bot:
[mediawiki/core@REL1_30] registration: Validate no duplicate keys exist in extension.json