Page MenuHomePhabricator

UnboundLocalError on Travis
Closed, ResolvedPublic

Description

___ TestLoadPagesFromPageids.test_load_from_pageids_iterable_with_duplicate ____
self = <tests.site_tests.TestLoadPagesFromPageids testMethod=test_load_from_pageids_iterable_with_duplicate>
    def test_load_from_pageids_iterable_with_duplicate(self):
        """Test loading with duplicate pageids."""
        pageids = [page._pageid for page in self.links]
        pageids = pageids + pageids
        gen = self.site.load_pages_from_pageids(pageids)
        for count, page in enumerate(gen, start=1):
            self.assertIsInstance(page, pywikibot.Page)
            self.assertIsInstance(page.exists(), bool)
            self.assertTrue(page.exists())
            self.assertTrue(hasattr(page, '_pageid'))
            self.assertIn(page, self.links)
>       self.assertEqual(count, len(self.links))
E       UnboundLocalError: local variable 'count' referenced before assignment
tests/site_tests.py:2550: UnboundLocalError

See: https://travis-ci.org/wikimedia/pywikibot-core/jobs/184925687#L1899

Event Timeline

Change 328043 had a related patch set uploaded (by Magul):
Fix UnboundLocalError for count uninitialized before loop

https://gerrit.wikimedia.org/r/328043

Dalba subscribed.

This has been fixed via 52ef3d6ae5423a0895bfac5c3d6fc3ddd64e322f.

Change 328043 abandoned by Dalba:
Fix UnboundLocalError for count uninitialized before loop

Reason:
52ef3d6ae5423a0895bfac5c3d6fc3ddd64e322f has fixed the issue.

https://gerrit.wikimedia.org/r/328043