Page MenuHomePhabricator

CentralAuthUser::chooseHomeWiki gets confused if all privileged accounts are blocked
Closed, DeclinedPublic

Description

When choosing the home wiki, if any accounts are in privileged groups, only the privileged accounts are considered for the home selection.

However, any blocked accounts are removed *after* this check. If all the privileged accounts are blocked at the moment (for instance, a sysop account who has blocked himself temporarily), the working set ends up being empty, no home wiki is chosen, and an exception is thrown.

The simplest solution is probably to strike out the blocked accounts before the privileged check; that is, just ignore any blocked accounts. This would, however, potentially allow a non-priveleged account to take advantage of a temporary or accidental block of a sysop account to take over.

If it's desired to block that condition, then a more friendly error should be returned instead of the low-level exception.


Version: unspecified
Severity: enhancement

Details

Reference
bz13512

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:05 PM
bzimport set Reference to bz13512.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 13671 has been marked as a duplicate of this bug. ***

thomas.dalton wrote:

I swear I searched for dupes before reporting - is bugzilla's search function broken? It didn't seem to find any bugs in this component.

thomas.dalton wrote:

Interesting distinction. I searched for any open bugs in this component whose summaries included the word "privileged" - how did this bug not come up? (I then searched for any bugs in this component and it still found nothing...)

Considering that I usually have to try four times and use a spell checker to spell 'privileged', I wouldn't be too surprised. :)

thomas.dalton wrote:

I'll admit to looking it up...

Was this fixed with I32384d6423d3cb633f99cdcd2745f8ce6d8c597e? I don't see anything in CentralAuthUser::chooseHomeWiki that has to do with blocks.

MarcoAurelio raised the priority of this task from Medium to High.May 5 2015, 6:14 PM
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.