Page MenuHomePhabricator
Create Task
Maniphest T155595

Remove getWikiBaseItemId from MobileFrontend
Closed, ResolvedPublic
Actions

Description

This method is not used anywhere anymore.

Details

SubjectRepoBranchLines +/-
Hygiene: Remove getWikiBaseItemId utilmediawiki/extensions/MobileFrontendmaster+0 -17
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jan 18 2017, 1:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2017, 1:11 AM
gerritbot subscribed.Jan 19 2017, 1:10 AM

Change 332923 had a related patch set uploaded (by Jdlrobson):
Hygiene: Remove getWikiBaseItemId util

https://gerrit.wikimedia.org/r/332923

gerritbot added a project: Patch-For-Review.Jan 19 2017, 1:10 AM
Jdlrobson added projects: Unplanned-Sprint-Work, Reading-Web-Sprint-90-🍌.Jan 20 2017, 7:26 PM
Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.
Jdlrobson claimed this task.Jan 23 2017, 5:24 PM
MBinder_WMF added subscribers: ovasileva, MBinder_WMF.Jan 23 2017, 6:18 PM

@ovasileva We should prioritize this. @Jdlrobson does this need pointing with the team?

Jdlrobson added a comment.Jan 23 2017, 6:50 PM

It's super minor. I was hoping someone should just +2. It removes dead code which isn't referenced anywhere. 0.5 if you want to point. This is one of those things that I hate having to push through our process. Writing and managing the ticket is more work than the change itself :)

MBinder_WMF added a comment.Jan 23 2017, 6:56 PM

OK, thanks for clarifying.

MBinder_WMF triaged this task as Medium priority.Jan 24 2017, 9:53 PM
• bmansurov moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-90-🍌 board.Jan 24 2017, 9:57 PM
gerritbot added a comment.Jan 24 2017, 10:04 PM

Change 332923 merged by jenkins-bot:
Hygiene: Remove getWikiBaseItemId util

https://gerrit.wikimedia.org/r/332923

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 24 2017, 11:00 PM
• bmansurov moved this task from Incoming to 2016-17 Q3 on the Web-Team-Backlog board.Jan 25 2017, 5:07 PM
phuedx closed this task as Resolved.Jan 25 2017, 7:03 PM
phuedx subscribed.

[There's no reference to getWikiBaseItemId across all of the Foundation-hosted MediaWiki extensions](https://github.com/search?q=org%3Awikimedia+getWikiBaseItemId) 👍

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL