Page MenuHomePhabricator

VE should recognize when a page already has pageprop disambig from a template
Open, LowPublic

Description

VE's 'Page settings' for "This is a disambiguation page", should recognize (add the checkmark) when an existing template on the page already adds the _DISAMBIG_ magic word.

E.g. at
https://test.wikipedia.org/wiki/User:Quiddity_(WMF)/sandboxdisambig
the {{disambig}} template has successfully added the magic word, per
https://test.wikipedia.org/w/index.php?title=User:Quiddity_(WMF)/sandboxdisambig&action=info#Page_properties
but the checkbox is unmarked:

Selection_001.png (612×1 px, 127 KB)

This might lead to people accidentally checking the box, thinking they have to do both.

Possibly related:

Event Timeline

Is it actually necessary to show that checkbox at all? Most if not all wikis set the property via templates, so normal pages actually never should use the __DISAMBIG__ magic word, and thus the checkbox never should be needed.

Just to add a few numbers: In de.wikipedia 3 articles had the __DISAMBIG__ keyword, all of these were added via VE, and all of these were wrong.

Perhaps we need to add flags like TOC , DISAMBIG and other behaviour switches into the metadata of the template usage as annotated by Parsoid, in order to at least be able to detect that these are already being added by a specific template call ?

That still won't help you find an appropriate template to for adding the behaviour, but at least will avoid you from adding it when not needed ?

Deskana moved this task from To Triage to Freezer on the VisualEditor board.