Page MenuHomePhabricator

#iferror should catch imagemap errors
Closed, InvalidPublic

Description

Author: rene.kijewski

Description:
If you enter a wrong syntax, imagemaps display: <p class="error">...</p>.

If it would be <p><span class="error">...</span></p>, errors could be caught by #iferror.


Version: unspecified
Severity: normal
URL: http://de.wikipedia.org/wiki/Benutzer:Finn-Pauls/Bug

Details

Reference
bz13620

Related Objects

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:05 PM
bzimport added a project: ParserFunctions.
bzimport set Reference to bz13620.
bzimport added a subscriber: Unknown Object (MLST).

rene.kijewski wrote:

Proposed patch

patch against rev 31730

attachment ImageMap_body.new.diff ignored as obsolete

Based on the discussion on http://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=44710904#K.C3.B6nntest_du_einen_Bugreport_f.C3.BCr_mich_umsetzen.3F

#iferror function from ParserFunctions.php modified with r33047 to catch more error messages.

derfinn wrote:

The patch didn't solve the problem obviously.

brion added a comment.Apr 11 2008, 6:50 PM

Please provide a URL demonstrating the error.

derfinn wrote:

(In reply to comment #4)

Please provide a URL demonstrating the error.

http://de.wikipedia.org/wiki/Benutzer:Finn-Pauls/Bug

Created attachment 5907
Strip the UNIQ markers

After discussion at http://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=57698683#Mal_wieder_ein_Wunsch_zu_einem_Bug see the attached patch which strips the UNIQ markers.

attachment strip.patch ignored as obsolete

rene.kijewski wrote:

Comment on attachment 5907
Strip the UNIQ markers

I withdraw the patch. It may mess around with <nowiki> tags.
It would be possible to parse the XML tree of $unstripped and look for the class error with xpath. But I guess this would be somewhat expensive.

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

The demo page has been deleted and there isn't enough information on the bug to duplicate this. If you reopen, please provide a demonstration of the problem.