<indicator> breaks parser tests
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	cscott
	Jan 25 2017, 8:06 PM

Description

I attempted to update lib/config/baseconfig/enwiki.json to the latest version on en.wikipedia.org, using tools/sync-baseconfig.js (see https://gerrit.wikimedia.org/r/334170 ). I got a bunch of errors when running parserTests, like:

19:10:02 [error][enwiki/Main Page] data-mw missing in: <span typeof="mw:Extension/indicator" about="#mwt1">&lt;indicator name=" "&gt;&lt;/indicator&gt;</span>
19:10:02 Stack:
19:10:02   MWParserEnvironment.log (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/bin/parserTests.js:1743:25)
19:10:02   Object.<anonymous> (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/lib/html2wt/DOMHandlers.js:1446:10)
19:10:02   /home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/prfun/lib/index.js:576:26
19:10:02   tryCatch2 (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/babybird/lib/promise.js:48:12)
19:10:02   PrFunPromise.Promise (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/babybird/lib/promise.js:458:15)
19:10:02   new PrFunPromise (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/prfun/lib/index.js:101:21)
19:10:02   /home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/prfun/lib/index.js:574:18
19:10:02   tryCatch1 (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/babybird/lib/promise.js:40:12)
19:10:02   promiseReactionJob (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/babybird/lib/promise.js:269:19)
19:10:02   PromiseReactionJobTask.call (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/babybird/lib/promise.js:284:3)
19:10:02   flush (/home/jenkins/workspace/parsoidsvc-source-npm-node-6-jessie/node_modules/asap/raw.js:50:29)
19:10:02   _combinedTickCallback (internal/process/next_tick.js:67:7)
19:10:02   process._tickCallback (internal/process/next_tick.js:98:9)

This seems to be because the new enwiki.json adds <indicator> to the extensiontags clause.

(There are also some failures because enwiki.json reorders thumbnail after thumb in img_thumbnail (but not in img_manualthumb!). That can be a separate task: T156296.