Page MenuHomePhabricator

VisualEditor-MediaWiki's REL1.28 makes ResourceLoader module session-dependent
Closed, DeclinedPublic1 Story Points

Description

MediaWiki 1.28, Visual Editor 0.1.0 (93528b7).

The script load.php?debug=false&lang=ru&modules=startup&only=scripts&skin=vector&* which is invoked from Special:Upload begins with:

/*
[da4dbb21224ac8367486c80b] /w/load.php?debug=false&lang=ru&modules=startup&only=scripts&skin=vector&*   BadMethodCallException from line 845 of /var/www/wiki/w/includes/session/SessionManager.php: Sessions are disabled for this entry point
*/
if (window.console && console.error) {console.error("[da4dbb21224ac8367486c80b] /w/load.php?debug=false\u0026lang=ru\u0026modules=startup\u0026only=scripts\u0026skin=vector\u0026*   BadMethodCallException from line 845 of (path to MediaWiki)/includes/session/SessionManager.php: Sessions are disabled for this entry point");}

It writes the message to the console log.

Switching Visual Editor off stops this.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2017, 4:21 PM
alex-mashin renamed this task from Visual Editor breaks Javascript making ResourceLoader module session-dependent to Visual Editor makes ResourceLoader module session-dependent.Jan 29 2017, 5:32 PM
alex-mashin updated the task description. (Show Details)
Jdforrester-WMF triaged this task as Low priority.Feb 14 2017, 8:27 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

I vaguely recall us fixing this; sounds like it missed the REL1_28 cut? Sadly there are ~500 commits since then. I imagine we just need to back-port that fix?

Jdforrester-WMF renamed this task from Visual Editor makes ResourceLoader module session-dependent to VisualEditor-MediaWiki's REL1.28 makes ResourceLoader module session-dependent.Feb 14 2017, 8:27 PM
Krinkle closed this task as Declined.Oct 2 2018, 8:18 PM
Krinkle added a subscriber: Krinkle.

The 1.28.x release line was ended November 2017 (info). Newer releases since then contain versions of VisualEditor and ResourceLoader that don't violate the MW_NO_SESSION constraint.

Please do file new tasks if similar issues are found again.