Page MenuHomePhabricator
Create Task
Maniphest T156594

VisualEditor-MediaWiki's REL1.28 makes ResourceLoader module session-dependent
Closed, DeclinedPublic1 Estimated Story Points
Actions

Description

MediaWiki 1.28, Visual Editor 0.1.0 (93528b7).

The script load.php?debug=false&lang=ru&modules=startup&only=scripts&skin=vector&* which is invoked from Special:Upload begins with:

/*
[da4dbb21224ac8367486c80b] /w/load.php?debug=false&lang=ru&modules=startup&only=scripts&skin=vector&*   BadMethodCallException from line 845 of /var/www/wiki/w/includes/session/SessionManager.php: Sessions are disabled for this entry point
*/
if (window.console && console.error) {console.error("[da4dbb21224ac8367486c80b] /w/load.php?debug=false\u0026lang=ru\u0026modules=startup\u0026only=scripts\u0026skin=vector\u0026*   BadMethodCallException from line 845 of (path to MediaWiki)/includes/session/SessionManager.php: Sessions are disabled for this entry point");}

It writes the message to the console log.

Switching Visual Editor off stops this.

Related Objects

Event Timeline

alex-mashin created this task.Jan 29 2017, 4:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2017, 4:21 PM
alex-mashin renamed this task from Visual Editor breaks Javascript making ResourceLoader module session-dependent to Visual Editor makes ResourceLoader module session-dependent.Jan 29 2017, 5:32 PM
alex-mashin updated the task description. (Show Details)
Jdforrester-WMF triaged this task as Low priority.Feb 14 2017, 8:27 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF subscribed.

I vaguely recall us fixing this; sounds like it missed the REL1_28 cut? Sadly there are ~500 commits since then. I imagine we just need to back-port that fix?

Jdforrester-WMF renamed this task from Visual Editor makes ResourceLoader module session-dependent to VisualEditor-MediaWiki's REL1.28 makes ResourceLoader module session-dependent.Feb 14 2017, 8:27 PM
Krinkle closed this task as Declined.Oct 2 2018, 8:18 PM
Krinkle subscribed.

The 1.28.x release line was ended November 2017 (info). Newer releases since then contain versions of VisualEditor and ResourceLoader that don't violate the MW_NO_SESSION constraint.

Please do file new tasks if similar issues are found again.

Krinkle added projects: MediaWiki-ResourceLoader, Performance-Team (Radar).Oct 2 2018, 8:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL