Page MenuHomePhabricator
Create Task
Maniphest T157172

Hard deprecation warnings on SpecialMobileDiff
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The following errors are occurring in the logs.

	Use of User::getGroupMember was deprecated in MediaWiki 1.29. [Called from SpecialMobileDiff::listGroups in /srv/mediawiki/php-1.29.0-wmf.10/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php at line 366]
	Use of User::makeGroupLinkHTML was deprecated in MediaWiki 1.29. [Called from SpecialMobileDiff::listGroups in /srv/mediawiki/php-1.29.0-wmf.10/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php at line 370]

According to https://www.mediawiki.org/wiki/Requests_for_comment/Deprecation_policy we should aim to get this removed before the next MediaWiki release. Sooner the best I say...

Details

SubjectRepoBranchLines +/-
Remove deprecated warnings on SpecialMobileDiffmediawiki/extensions/MobileFrontendmaster+10 -12
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Feb 3 2017, 10:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2017, 10:20 PM
Jdlrobson triaged this task as High priority.Feb 3 2017, 10:20 PM
Jdlrobson moved this task from Unsorted to Needs removal on the Technical-Debt board.
Jdlrobson mentioned this in T151837: [2hrs] Production warning: Undefined index: token in InlineDifferenceEngine.
ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Feb 6 2017, 7:50 PM
ovasileva added a project: Reading-Web-Sprint-92-🍜.
Jdlrobson set the point value for this task to 2.Feb 6 2017, 7:52 PM
• bmansurov edited projects, added Technical-Debt (RW-Tech-Debt); removed Technical-Debt.Feb 15 2017, 6:21 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-92-🍜 board.Feb 15 2017, 6:23 PM
ovasileva moved this task from Upcoming to 2016-17 Q3 on the Web-Team-Backlog board.Feb 17 2017, 12:04 PM
pmiazga claimed this task.Feb 17 2017, 4:34 PM
pmiazga moved this task from To Do to Doing on the Reading-Web-Sprint-92-🍜 board.
gerritbot subscribed.Feb 17 2017, 6:37 PM

Change 338396 had a related patch set uploaded (by Pmiazga):
Remove deprecated warnings on SpecialMobileDiff

https://gerrit.wikimedia.org/r/338396

gerritbot added a project: Patch-For-Review.Feb 17 2017, 6:37 PM
pmiazga moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-92-🍜 board.Feb 20 2017, 3:22 PM
gerritbot added a comment.Feb 21 2017, 11:47 AM

Change 338396 merged by jenkins-bot:
Remove deprecated warnings on SpecialMobileDiff

https://gerrit.wikimedia.org/r/338396

phuedx reassigned this task from pmiazga to • bmansurov.Feb 21 2017, 11:59 AM
phuedx moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-92-🍜 board.
phuedx added subscribers: • bmansurov, pmiazga, phuedx.

This is a technical task. Over to you @bmansurov!

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)).Feb 21 2017, 12:00 PM
• bmansurov closed this task as Resolved.Feb 28 2017, 9:25 PM
• bmansurov removed • bmansurov as the assignee of this task.

No deprecation warnings.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits