Page MenuHomePhabricator
Create Task
Maniphest T157373

Few technical improvements to Kartographer styles
Closed, ResolvedPublic
Actions

Description

@Esanders made a few patches to Kartographer :

Let's get these reviewed and merged :)

Details

SubjectRepoBranchLines +/-
Add standard border to map details sidebarmediawiki/extensions/Kartographermaster+2 -1
Use class names to avoid generic tag name selectors for styling tablesmediawiki/extensions/Kartographermaster+60 -60
Fix border colour in map dialogmediawiki/extensions/Kartographermaster+3 -11
Customize query in gerrit

Event Timeline

• JGirault created this task.Feb 6 2017, 7:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2017, 7:26 PM
• JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.Feb 6 2017, 7:27 PM
• JGirault added a subscriber: Jdforrester-WMF.
gerritbot subscribed.Feb 6 2017, 11:15 PM

Change 333717 had a related patch set uploaded (by JGirault):
Fix border colour in map dialog

https://gerrit.wikimedia.org/r/333717

gerritbot added a project: Patch-For-Review.Feb 6 2017, 11:15 PM
gerritbot added a comment.Feb 6 2017, 11:21 PM

Change 333717 merged by jenkins-bot:
Fix border colour in map dialog

https://gerrit.wikimedia.org/r/333717

gerritbot added a comment.Feb 6 2017, 11:38 PM

Change 333718 had a related patch set uploaded (by JGirault):
Use class names to avoid generic tag name selectors for styling tables

https://gerrit.wikimedia.org/r/333718

gerritbot added a comment.Feb 6 2017, 11:49 PM

Change 333718 merged by jenkins-bot:
Use class names to avoid generic tag name selectors for styling tables

https://gerrit.wikimedia.org/r/333718

gerritbot added a comment.Feb 6 2017, 11:52 PM

Change 333719 had a related patch set uploaded (by JGirault):
Add standard border to map details sidebar

https://gerrit.wikimedia.org/r/333719

gerritbot added a comment.Feb 6 2017, 11:57 PM

Change 333719 merged by jenkins-bot:
Add standard border to map details sidebar

https://gerrit.wikimedia.org/r/333719

• JGirault added a comment.Feb 6 2017, 11:58 PM

All patches reviewed, amended a little, and merged. Moving to the Done column.

• JGirault moved this task from Needs review to Done on the Maps-Sprint board.Feb 6 2017, 11:59 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)).Feb 7 2017, 12:01 AM
• JGirault closed this task as Resolved.Apr 17 2017, 7:36 PM
• JGirault updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL