Page MenuHomePhabricator
Create Task
Maniphest T157389

In Safari, VE crashes while trying to save a page after adding a Map/Graph
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page with VE in Safari
  2. Add a map or a Graph
  3. Click on "Save"

Observe that, there is an error in the console "createElementInvalidCharacterError: DOM Exception 5: An invalid or illegal character was specified, such as in an XML name" and VE fails to save the page after that.

Screen Shot 2017-02-06 at 9.42.37 PM.png (774×1 px, 354 KB)

Details

SubjectRepoBranchLines +/-
Define default HTML types for extension nodesmediawiki/extensions/VisualEditormaster+6 -0
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Feb 6 2017, 9:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2017, 9:44 PM
Ryasmeen renamed this task from In Safari, VE crashes while trying to save a page after adding a map to In Safari, VE crashes while trying to save a page after adding a Map/Graph.Feb 6 2017, 9:51 PM
Ryasmeen updated the task description. (Show Details)
SamanthaNguyen added projects: Maps, MediaWiki-extensions-Graph, Browser-Support-Apple-Safari.Feb 6 2017, 10:33 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptFeb 6 2017, 10:33 PM
Jdforrester-WMF triaged this task as High priority.Feb 7 2017, 8:08 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a subscriber: Esanders.
gerritbot subscribed.Feb 7 2017, 8:13 PM

Change 336464 had a related patch set uploaded (by Esanders):
Define default HTML types for extension nodes

https://gerrit.wikimedia.org/r/336464

gerritbot added a project: Patch-For-Review.Feb 7 2017, 8:13 PM
gerritbot added a comment.Feb 7 2017, 8:44 PM

Change 336464 merged by jenkins-bot:
Define default HTML types for extension nodes

https://gerrit.wikimedia.org/r/336464

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 7 2017, 9:00 PM
Ryasmeen closed this task as Resolved.Feb 10 2017, 9:20 PM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 10 2017, 9:20 PM
Jdforrester-WMF assigned this task to Esanders.Feb 13 2017, 5:21 PM
Ryasmeen added a project: Verified-in-Phase0.Feb 15 2017, 8:15 PM
Ryasmeen added a project: Verified-in-Phase2.Feb 16 2017, 9:58 PM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits