Page MenuHomePhabricator

[Premoderation] ErrorPageError from line 74 of Premoderation.class.php: Your revision has been added to the moderation queue
Closed, DeclinedPublic

Description

From https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/36433/console for https://gerrit.wikimedia.org/r/#/c/336091/

14:18:05 [86ddd64ef85cc8828e27189e] [no req]   ErrorPageError from line 74 of /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Premoderation/Premoderation.class.php: Your revision has been added to the moderation queue. It will be published or declined by moderator
14:18:05 Backtrace:
14:18:05 #0 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/includes/Hooks.php(186): Premoderation::processEditRequest(WikiPage, User, WikitextContent, string, integer, NULL, NULL, integer, Status)
14:18:05 #1 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/includes/page/WikiPage.php(1602): Hooks::run(string, array)
14:18:05 #2 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php(1050): WikiPage->doEditContent(WikitextContent, string, integer, boolean, User)
14:18:05 #3 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php(382): MediaWikiTestCase->addCoreDBData()
14:18:05 #4 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): MediaWikiTestCase->run(PHPUnit_Framework_TestResult)
14:18:05 #5 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult)
14:18:05 #6 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult)
14:18:05 #7 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult)
14:18:05 #8 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(440): PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult)
14:18:05 #9 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/phpunit/phpunit/src/TextUI/Command.php(149): PHPUnit_TextUI_TestRunner->doRun(PHPUnit_Framework_TestSuite, array)
14:18:05 #10 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/vendor/phpunit/phpunit/src/TextUI/Command.php(100): PHPUnit_TextUI_Command->run(array, boolean)
14:18:05 #11 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/phpunit.php(133): PHPUnit_TextUI_Command::main()
14:18:05 #12 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/maintenance/doMaintenance.php(111): PHPUnitMaintClass->execute()
14:18:05 #13 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/phpunit.php(163): include(string)
14:18:05 #14 {main}

Event Timeline

Nemo_bis created this task.Feb 7 2017, 7:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2017, 7:26 AM
Nemo_bis triaged this task as Medium priority.Feb 7 2017, 7:29 AM
Nemo_bis updated the task description. (Show Details)

@Nemo_bis: Do you plan to work on this task (or have you talked to maintainers and they stated they plan to work on this), or why did you set the Priority to "Normal" here?

Aklapper lowered the priority of this task from Medium to Lowest.Feb 21 2017, 4:57 PM
Nemo_bis raised the priority of this task from Lowest to Medium.Feb 23 2017, 1:39 PM

Fatals are "normal".

hashar added a subscriber: hashar.Jun 5 2018, 5:37 PM

Premoderation throws an ErrorPageError exception whenever a page is edited. The failure is triggered when MediaWikiTestCase inserts a test page ( MediaWikiTestCase->addCoreDBData() then WikiPage->doEditContent() ). So hmm it is broken.

Does MediaWikiTestCase->addCoreDBData() account for the fact that a wiki may not authorise all users to actually save (publish) their edits immediately?

hashar closed this task as Declined.Jul 6 2018, 11:10 AM

The Premoderation extension is being archived T198952