Maniphest T158349

Isolate page data client responsibilities
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	Feb 16 2017, 8:02 PM

Tags

Referenced Files

None

Subscribers

• Niedzielski

Description

Remove PageLoadStrategy
Rename PageDataClient to PageLoadStrategy
Move page data client responsibilities from PageLoadStrategy to a new class, PageDataClient
Move the tests; tests around page loading logic can probably be dropped (see also T157605), tests around the data client should appear under PageDataClientTest

Related Objects

Mentioned Here: T156917: Replace custom saved pages cache with OkHttp cache
T157605: Fix PageLoadTest timeouts

Event Timeline

• Niedzielski created this task.Feb 16 2017, 8:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2017, 8:02 PM

• Niedzielski raised the priority of this task from Medium to High.Feb 16 2017, 8:02 PM

Dbrant moved this task from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.Feb 22 2017, 5:46 PM

• Mholloway subscribed.Feb 23 2017, 7:32 PM

• Mholloway updated the task description. (Show Details)Sep 22 2017, 5:00 PM

Looks like this work got completed in the course of T156917.