Page MenuHomePhabricator

RC filters - Console errors for clicking on selected filters
Closed, ResolvedPublic

Description

Split from T157852: RCFilters UI: When removing a capsule item, its popup remains visible

Only in Chrome and Safari - FF does not display any Console errors.

Every time I click on selected filter with a tooltip displayed, I got the Console errors (look below). It doesn't seem to be affecting anything - any concerns about it?

Uncaught TypeError: Cannot read property 'val' of null(…)
OO.ui.CapsuleMultiselectWidget.editItem
OO.ui.CapsuleItemWidget.onClick
dispatch
elemData.handle

With filters "Newcomers", "Unregistered" (conflicting state), the click on selected greyed-out filters gives

Uncaught TypeError: Cannot read property 'val' of null
 at MwRcfiltersUiFilterCapsuleMultiselectWidget.OO.ui.CapsuleMultiselectWidget.editItem (eval at <anonymous>
 at MwRcfiltersUiCapsuleItemWidget.OO.ui.CapsuleItemWidget.onClick (eval at <anonymous> 
 at HTMLDivElement.dispatch
 at HTMLDivElement.elemData.handle

Safari displays a differently phrased error:

TypeError: null is not an object (evaluating 'this.$input.val')
editItem 
onClick 
dispatch  
handle

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2017, 11:48 PM

Change 338295 had a related patch set uploaded (by Mooeypoo):
RCFilters UI: Cancel 'editItem' on CapsuleMultiselectWidget

https://gerrit.wikimedia.org/r/338295

Change 338295 merged by jenkins-bot:
RCFilters UI: Cancel 'editItem' on CapsuleMultiselectWidget

https://gerrit.wikimedia.org/r/338295

Checked the fix in betalabs - no more Console errors.

QA recommendation: Resolve.

jmatazzoni closed this task as Resolved.Feb 23 2017, 11:27 PM