Page MenuHomePhabricator
Create Task
Maniphest T158374

[EPIC] Reduce use of SmashPig\Core\Configuration where possible
Closed, ResolvedPublic
Actions

Description

Let's make it easier to move to some other kind of dependency injection and provide config values to utility classes via setters or constructor parameters.

Details

SubjectRepoBranchLines +/-
Move Ingenico base API wrapper functions to own classwikimedia/fundraising/SmashPigmaster+138 -49
Get some static Config access out of Authenticatorwikimedia/fundraising/SmashPigmaster+24 -20
Reduce Configuration use in BankPaymentProviderwikimedia/fundraising/SmashPigmaster+46 -16
Customize query in gerrit

Event Timeline

Ejegg created this task.Feb 17 2017, 12:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2017, 12:50 AM
gerritbot subscribed.Feb 17 2017, 12:53 AM

Change 338300 had a related patch set uploaded (by Ejegg):
Get some static Config access out of Authenticator

https://gerrit.wikimedia.org/r/338300

gerritbot added a project: Patch-For-Review.Feb 17 2017, 12:53 AM
gerritbot added a comment.Feb 17 2017, 1:25 AM

Change 338303 had a related patch set uploaded (by Ejegg):
Move Ingenico base API wrapper functions to own class

https://gerrit.wikimedia.org/r/338303

gerritbot added a comment.Feb 17 2017, 1:45 AM

Change 338306 had a related patch set uploaded (by Ejegg):
Reduce Configuration use in BankPaymentProvider

https://gerrit.wikimedia.org/r/338306

• ggellerman renamed this task from Reduce use of SmashPig\Core\Configuration where possible to [EPIC] Reduce use of SmashPig\Core\Configuration where possible.Feb 21 2017, 10:08 PM
• ggellerman triaged this task as Medium priority.
• ggellerman added a project: Epic.
• ggellerman moved this task from Triage to Sprint +2 on the Fundraising-Backlog board.
gerritbot added a comment.Feb 22 2017, 8:49 PM

Change 338306 merged by jenkins-bot:
Reduce Configuration use in BankPaymentProvider

https://gerrit.wikimedia.org/r/338306

gerritbot added a comment.Feb 22 2017, 8:49 PM

Change 338300 merged by jenkins-bot:
Get some static Config access out of Authenticator

https://gerrit.wikimedia.org/r/338300

gerritbot added a comment.Feb 22 2017, 10:30 PM

Change 338303 merged by jenkins-bot:
Move Ingenico base API wrapper functions to own class

https://gerrit.wikimedia.org/r/338303

• DStrine moved this task from Sprint +2 to FY 2022-2023 on the Fundraising-Backlog board.May 6 2019, 9:24 PM
Umherirrender closed this task as Resolved.Apr 5 2022, 7:49 PM
Umherirrender removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL