Page MenuHomePhabricator

Keyholder: add support for ED25519 keys
Closed, ResolvedPublic

Description

Keyholder is supposed to accept only RSA SSH Keys according to it's source code, but due to T158660, any key is actually working.

Once T158660 will be merged, new ed25519 keys will not be anymore supported.

Event Timeline

Volans renamed this task from Keyholder: to Keyholder: add support for ED25519 keys.Feb 21 2017, 6:22 PM
Volans claimed this task.
Volans triaged this task as Medium priority.
Volans updated the task description. (Show Details)

Change 339002 had a related patch set uploaded (by Volans):
Keyholder: add support for ed25519 keys

https://gerrit.wikimedia.org/r/339002

Volans moved this task from In Progress to In Code Review on the SRE-tools board.

Change 339002 merged by Volans:
Keyholder: add support for ed25519 keys

https://gerrit.wikimedia.org/r/339002

Mentioned in SAL (#wikimedia-operations) [2017-02-24T14:27:37Z] <volans> re-started and re-armed keyholder after upgrade on: mira.codfw.wmnet,neodymium.eqiad.wmnet,sarin.codfw.wmnet,tin.eqiad.wmnet T158660 T158659

Volans moved this task from In Code Review to Done on the SRE-tools board.