Page MenuHomePhabricator

Special:Emailuser should have an input form
Closed, ResolvedPublic

Description

If you enter [[Special:Emailuser]] without specifying the target user, you get the following error message:

"You have not specified a target page or user on which to perform this function."

It'd be great to have an input mask instead, where you can just enter the user name and get the page Special:Emailuser/username (or Special:Emailuser?target=username).
I think, this is also how it's done in Special:Contributions


Version: unspecified
Severity: enhancement

Details

Reference
bz13879

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:14 PM
bzimport set Reference to bz13879.

Created attachment 4891
Patch against head, implements a "specify user" form

This patch will implement a "Specify user" form if there is no target user.

attachment diff.patch ignored as obsolete

Comment on attachment 4891
Patch against head, implements a "specify user" form

Bad patch against current trunk with EmailUser refactor. Looking at rewriting this patch again and better implementing it.

Bryan.TongMinh wrote:

I suggest that we just make the "To" field an input box and show the full form when errors occur.

Assigned: demon (who probably just forgot he commented here)

Bryan.TongMinh wrote:

Fixed in r39793.

Bumping with comments from the revert:

  • (bug 13879) Special:EmailUser shows a form in case no user was specified" for the moment
  • Recipient name seems to be output raw into HTML form; this is insecure
  • We've lost the link to the target's user page in the primary use case (followed 'email this user' link)
  • Behavior if you misspell a name doesn't look very nice; you can't just fix it and resubmit the form, you have to hit 'back' from an error page and hope your browser isn't one that deletes all your form data :D
  • Bug 19679 has been marked as a duplicate of this bug. ***

Maybe WONTFIX, per bug 13349 comment 3?

bug 13349 comment 3 means that Emailuser shouldn't bve listed there until it gets an input form, which is quite different than "it can't have an input form".

Special:MovePage can also have a input form, but he does not, because the page is "task-oriented, to be reached directly from their tasks", the same for Emailuser. The task "send email" is started when click the link on the userpage.

In the meantime, I changed my mind and now I agree with Umherirrender. There are lots of special pages that require parameters and don't have an input form. If they're unlisted (i.e. not in Special:Specialpages), that's okay.

(In reply to comment #13)

In the meantime, I changed my mind and now I agree with Umherirrender. There
are lots of special pages that require parameters and don't have an input form.
If they're unlisted (i.e. not in Special:Specialpages), that's okay.

This seems like a reason to fix the other forms, not keep them as they are.

And why should a page like Special:RevisionDelete have a form? They have an input form, it's just not on the special page itself, but somewhere it belongs (in case of RevisionDelete, it's in the page history and diffs).

(In reply to comment #14)

(In reply to comment #13)

In the meantime, I changed my mind and now I agree with Umherirrender. There
are lots of special pages that require parameters and don't have an input form.
If they're unlisted (i.e. not in Special:Specialpages), that's okay.

This seems like a reason to fix the other forms, not keep them as they are.

+1. REOPENING.