Page MenuHomePhabricator

DonationInterface Vendor repo double inclusions
Closed, ResolvedPublic1 Estimated Story Points

Description

So... How is the DonationInterface vendor brought in?

Is there some way we can stop including dependencies that are bundled in the core WMF vendor repo? Or, is the current version some work around against using an older branch of MW?

psr/log, monolog and zordius/lightncandy (at least) are in the WMF core vendor repo...

Event Timeline

ggellerman set the point value for this task to 1.

It's a workaround for using DonationInterface outside of MediaWiki - we also load it under CiviCRM to do recurring payments. We're trying to pull out all that logic into a separate library, but for now we need to list those dependencies in composer.json.

I know this situation means we have to make sure we're on the same version as the MW branch running on payments. Are there any further issues?

Mostly it just annoys PhpStorm... I have everything cloned, so it has multiple copies of the vendor repo, which means multiple copies of these libraries..

But if you're loading the whole repo to reuse those modules under Civi too... Loading it all is needed, unless you were cloning the mw core vendor one too and loading that in too...

Ejegg claimed this task.

OK, we're now using composer-merge-plugin to pull extension dependencies in to paymentswiki's vendor repo.