Signature button is always disabled on namespaces in which VE isn't allowed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Elitre
	Feb 28 2017, 10:07 AM

Description

As per this user's comment at mw.org and my own question some days ago, signing looks broken, as in, the related button can never be used, no matter which site or namespace I'm on. My current workaround is adding tildes via the special characters menu, which is meh.

(Triaging as high just in case it is actually a regression that needs to be fixed ASAP, so James can find it at the triage meeting later today).

Details

	Subject	Repo	Branch	Lines +/-
	Allow the signature button to work in NWE as well as VE	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T157286: Inconsistent availability of "Insert signature" between the visual editor and the 2017 source editor

Event Timeline

• Elitre created this task.Feb 28 2017, 10:07 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 28 2017, 10:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Elitre triaged this task as High priority.Feb 28 2017, 10:08 AM

• Elitre updated the task description. (Show Details)

• Elitre added a subscriber: • Whatamidoing-WMF.

Jdforrester-WMF claimed this task.Feb 28 2017, 9:40 PM

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 340374 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Allow the signature button to work in NWE as well as VE

https://gerrit.wikimedia.org/r/340374

gerritbot added a project: Patch-For-Review.Feb 28 2017, 9:41 PM

Jdforrester-WMF renamed this task from [regression?] Signature button is always greyed out to [regression?] Signature button is always disabled on namespaces in which VE isn't allowed.Feb 28 2017, 9:41 PM

Jdforrester-WMF renamed this task from [regression?] Signature button is always disabled on namespaces in which VE isn't allowed to Signature button is always disabled on namespaces in which VE isn't allowed.Feb 28 2017, 10:22 PM

Change 340374 merged by jenkins-bot:
Allow the signature button to work in NWE as well as VE

https://gerrit.wikimedia.org/r/340374

Jdforrester-WMF closed this task as Resolved.Feb 28 2017, 10:54 PM

Jdforrester-WMF removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Feb 28 2017, 11:00 PM

Framawiki subscribed.Mar 3 2017, 5:50 PM

• Elitre mentioned this in T157286: Inconsistent availability of "Insert signature" between the visual editor and the 2017 source editor.Mar 10 2017, 3:18 PM