Page MenuHomePhabricator

SpecialUpload warning results in long buttons
Closed, InvalidPublic

Description

screenshot if a long button on commons, sadly my screen isn't wide enough to see the whole button

Per r32493 the button on commons for save file on warning gets really long, see attachment.


Version: unspecified
Severity: normal

Attached:

long_button.png (1×1 px, 227 KB)

Details

Reference
bz13928

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:10 PM
bzimport set Reference to bz13928.

The original MediaWiki messages is "ignore warning and save file anyway". It doesn't generate a large button. The problem happens because http://commons.wikimedia.org/wiki/MediaWiki:Ignorewarning is changed from the original message. The person who changed it didn't notice that '''bolding text''' doesn't have an effect on buttons, and didn't pay attention that he is generating large buttons.

All in all, this is not a bug in MediaWiki, and should be fixed on Commons. If there is a real need to show that warning to users, another message can be added (by a separate request on Bugzilla, for example) about it.

ayg wrote:

Disagree, the changes introduced by r32493 were almost certainly mistakes. The 'ignorewarning' and 'reuploaddesc' messages formerly accepted wikitext and now do not, with no explanation given, and the 'savefile' and 'reupload' messages are now no longer used, but they were not removed from the message list. The latter two are supposed to be the labels for the buttons, the former two are supposed to be descriptions. I would revert this, but there are conflicts.

(In reply to comment #2)

Disagree, the changes introduced by r32493 were almost certainly mistakes. The
'ignorewarning' and 'reuploaddesc' messages formerly accepted wikitext and now
do not, with no explanation given, and the 'savefile' and 'reupload' messages
are now no longer used, but they were not removed from the message list. The
latter two are supposed to be the labels for the buttons, the former two are
supposed to be descriptions. I would revert this, but there are conflicts.

My intention was to simplify the form a bit and kill the ugly table construction. But I missed to remove the two now unused messages and the usage of wikitext in buttons.

Assigned: Raimond. To either mark resolved, or to fix and mark resolved after
that :)

Raimond, what's the status of this bug please?

EN.WP.ST47 wrote:

This bug as written is not a MediaWiki bug, the issue was with common localization, and it was fixed years ago. There seems to be some residual question regarding whether those messages should exist or accept wikitext, but since the person who made the change hasn't commented in three years and no one else seems particularly broken up, I'm marking invalid.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM