Page MenuHomePhabricator

Firefox/Mac vertical alignment in widgets is off
Closed, ResolvedPublic

Description

Firefox/Mac's doesn't vertical align the text of widgets correctly with the current combinations of line-height. There seems to actually be a miscalculation in Chrome rendering the line-height: 15px versus line-height: 16px in Firefox.

Chrome/Mac | Firefox/Mac with sans-serif

T159580-Vertical-alignment-buttons---Chrome_Fx-hidpi-_-OOjs-UI-Demos-2017-03-03.png (908×1 px, 124 KB)

As comparison Firefox 51/Win:

T159580 Vertical alignment buttons - Firefox Win _ OOjs UI Demos 2017-03-03.png (930×1 px, 352 KB)

Event Timeline

Volker_E changed the task status from Open to Stalled.Mar 3 2017, 10:49 PM

I must have been in a fever dream when I thought I found the reason for this. Meant to find fallback font as root of that problem in my tests. Can't reproduce that assumption though.

Volker_E renamed this task from Firefox/Mac vertical alignment in widgets is off due to `font-family: sans-serif` to Firefox/Mac vertical alignment in widgets is off.Mar 4 2017, 2:18 AM
Volker_E changed the task status from Stalled to Open.
Volker_E updated the task description. (Show Details)

Change 341117 had a related patch set uploaded (by volker-e):
[oojs/ui] [WIP] Correct Firefox vertical alignment of “framed” widgets

https://gerrit.wikimedia.org/r/341117

@Volker_E , is this causing the problem caught at https://drive.google.com/open?id=0B0TFyNZz_0j9SW5VNVZ3SnZmZzQ (first button slightly smaller than the big Save one)?

@Elitre It's kinda related, but not the same. It's T113495 and T122503.

@Etonkovidova It'd be great to have your help on comparing the proposed patch across browsers/platforms.

Change 341117 merged by jenkins-bot:
[oojs/ui] MediaWiki theme: Align “framed” ButtonWidgets cross-browser

https://gerrit.wikimedia.org/r/341117

Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.