Page MenuHomePhabricator
Create Task
Maniphest T122503

Edit link panel has uneven height of OOUI buttons in desktop Safari
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Screen Shot 2015-12-28 at 13.29.07.png (122×423 px, 16 KB)

Seeing this with Safari on mediawik.org
Demo was added in https://gerrit.wikimedia.org/r/#/c/342321/

Details

SubjectRepoBranchLines +/-
MediaWiki theme: Align “framed” ButtonWidgets cross-browseroojs/uimaster+12 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.Dec 28 2015, 12:30 PM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added a project: VisualEditor-EditingTools.
TheDJ subscribed.
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 28 2015, 12:30 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Jdforrester-WMF renamed this task from Edit link panel has uneven height of oojs buttons to Edit link panel has uneven height of OOUI buttons in desktop Safari.Jan 19 2016, 8:13 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF added projects: Browser-Support-Apple-Safari, OOUI.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Volker_E subscribed.Mar 9 2017, 5:31 AM

Related to T113495: Buttons in ButtonGroupWidget don't have same height/are misaligned

Volker_E added a parent task: T130691: Sub-pixel rendering layout issues with `em` or `%` relative units (tracking).Mar 9 2017, 5:32 AM
Volker_E mentioned this in T159580: Firefox/Mac vertical alignment in widgets is off.
Volker_E added a comment.EditedMar 12 2017, 4:45 AM

It's still reproducible on latest Safari 10.0.3/Mac. The reason behind this is line-height of iconElement is 15px and labelElement is 16px unlike Chrome. Firefox plays a different game and needs a line-height greater one. We're obviously not doing ourselves a favor by relying on other values than line-height: 1 to position the label within buttons.
The cross-browser solution that I've found still relies on line-height, but tries to tame it's influence and normalize its calculation.

gerritbot subscribed.Mar 12 2017, 6:22 AM

Change 341117 had a related patch set uploaded (by VolkerE):
[oojs/ui] MediaWiki theme: Align “framed” ButtonWidgets cross-browser

https://gerrit.wikimedia.org/r/341117

gerritbot added a project: Patch-For-Review.Mar 12 2017, 6:22 AM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Mar 12 2017, 6:25 AM
Volker_E updated the task description. (Show Details)Mar 12 2017, 6:28 AM
gerritbot added a comment.Mar 14 2017, 6:07 PM

Change 341117 merged by jenkins-bot:
[oojs/ui] MediaWiki theme: Align “framed” ButtonWidgets cross-browser

https://gerrit.wikimedia.org/r/341117

Volker_E moved this task from Reviewing to OOjs-UI-0.20.0 on the OOUI board.Mar 14 2017, 6:32 PM
Volker_E edited projects, added OOUI (OOjs-UI-0.20.0); removed OOUI.
Volker_E claimed this task.Mar 17 2017, 7:59 PM
Volker_E removed a project: Patch-For-Review.
Volker_E closed this task as Resolved.Mar 22 2017, 11:10 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 22 2017, 11:10 PM
Jdforrester-WMF moved this task from Freezer to External and Administrivia on the VisualEditor board.Mar 24 2017, 12:45 AM
Jdforrester-WMF changed the point value for this task from 8 to 0.
Jdforrester-WMF changed the point value for this task from 0 to 8.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits