Page MenuHomePhabricator

GenerateFancyCaptchas output a little spurious
Closed, ResolvedPublic

Description

Noticed while poking T159581

reedy@terbium:~$ /usr/local/bin/mwscript extensions/ConfirmEdit/maintenance/GenerateFancyCaptchas.php mediawikiwiki --wordlist=/etc/fancycaptcha/words --font=/usr/share/fonts/truetype/freefont/FreeMonoBoldOblique.ttf --blacklist=/etc/fancycaptcha/badwords --fill=100 --oldcaptcha
Current number of captchas is 1.
Generating 99 new captchas.. Done.

Generated 99 captchas in 17.0 seconds
Copying the new captchas to storage... Done.

Copied 293 captchas to storage in 2.3 seconds
Removing temporary files... Done.

Whole captchas generation process took 19.4 seconds
reedy@terbium:~$

How can it generate 99, but copy 293? Some weird issue with iterator_count?

Event Timeline

https://gerrit.wikimedia.org/r/#/c/341115/ may help make this a bit more clear (already merged)

Change 341590 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit] Remove entirely pointless directory iteration in GenerateFancyCaptchas

https://gerrit.wikimedia.org/r/341590

Change 342021 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit] Remove entirely pointless directory iteration in GenerateFancyCaptchas

https://gerrit.wikimedia.org/r/342021

Reedy assigned this task to Tgr.