Page MenuHomePhabricator
Create Task
Maniphest T160130

[Regression pre-wmf.16] Edit summary is showing previous session's edit summary
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Apparently https://gerrit.wikimedia.org/r/#/c/342083/ made the edit summary sticky not just while switching but also between separate edit sessions.
Steps to reproduce:

  1. Open VE
  2. Edit something
  3. On the save page dialog provide a summary
  4. Switch to NWE
  5. Switch back to VE
  6. Save the page.
  7. Now open VE again.
  8. Edit something
  9. Open Save dialog

Observe that the Edit Summary of previous session is still there although its a new edit session.

Another bad side effect of this is, during step 7 if you open VE through a section edit link, Edit Summary is now not showing the name of that section anymore.

Details

SubjectRepoBranchLines +/-
DesktopArticleTarget: Discard edit summary when canceling an editmediawiki/extensions/VisualEditormaster+1 -0
DesktopArticleTarget: Clear stored summary value after save completesmediawiki/extensions/VisualEditormaster+5 -0
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Mar 9 2017, 10:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2017, 10:56 PM
Ryasmeen renamed this task from [Regression ore-wmf.16] Edit summary is showing previous session's edit summary to [Regression pre-wmf.16] Edit summary is showing previous session's edit summary .Mar 9 2017, 10:56 PM
DLynch claimed this task.Mar 9 2017, 11:18 PM
gerritbot subscribed.Mar 9 2017, 11:26 PM

Change 342143 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor] DesktopArticleTarget: Clear stored summary value after save completes

https://gerrit.wikimedia.org/r/342143

gerritbot added a project: Patch-For-Review.Mar 9 2017, 11:26 PM
Jdforrester-WMF closed this task as Resolved.Mar 10 2017, 8:24 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki, Regression; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 10 2017, 8:24 PM
gerritbot added a comment.Mar 10 2017, 8:32 PM

Change 342143 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] DesktopArticleTarget: Clear stored summary value after save completes

https://gerrit.wikimedia.org/r/342143

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)).Mar 10 2017, 9:00 PM
Ryasmeen reopened this task as Open.EditedMar 11 2017, 1:15 AM

Hmm there is still one case where it is reproducible, when I discard the Edit session instead of saving.

Steps are here:

  1. Open VE
  2. Edit something
  3. On the save page dialog provide a summary

4.Switch to NWE
5.Switch back to VE
6.Click on "Read" tab

  1. Discard Edit

8.Now open VE again.
9.Edit something
10.Open Save dialog

Observe that the Edit Summary of previous session is still there although its a new edit session.

gerritbot added a comment.Mar 14 2017, 3:53 PM

Change 342641 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor] DesktopArticleTarget: Discard edit summary when canceling an edit

https://gerrit.wikimedia.org/r/342641

gerritbot added a project: Patch-For-Review.Mar 14 2017, 3:53 PM
gerritbot added a comment.Mar 14 2017, 4:10 PM

Change 342641 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] DesktopArticleTarget: Discard edit summary when canceling an edit

https://gerrit.wikimedia.org/r/342641

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)); removed MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)).Mar 14 2017, 5:00 PM
Jdforrester-WMF closed this task as Resolved.Mar 14 2017, 5:20 PM

Hopefully now double-resolved. :-)

Ryasmeen edited projects, added Verified; removed Patch-For-Review.Mar 14 2017, 6:08 PM
Ryasmeen added a project: Verified-in-Phase0.Mar 14 2017, 10:10 PM
Ryasmeen added a project: Verified-in-Phase2.Mar 17 2017, 12:27 AM
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)); removed MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)).Mar 20 2017, 6:15 PM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 28 2017, 11:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits