Page MenuHomePhabricator
Create Task
Maniphest T160141

Coord::bboxAround() works only on Earth
Closed, ResolvedPublic
Actions

Description

Math::wrapAround( $res->lon1, $res->lon2, -180, 180 );

Needs to take the globe into account.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add Mars and Venus as allowed globesmediawiki/extensions/GeoDatamaster+20 -13
Allow the Moon as alternative globe in all APIsmediawiki/extensions/GeoDatamaster+29 -26
Various code cleanups and modernizationsmediawiki/extensions/GeoDatamaster+76 -85
Accept Globes as objects in many more placesmediawiki/extensions/GeoDatamaster+41 -25
Move misplaced bboxAround function into BoundingBox classmediawiki/extensions/GeoDatamaster+29 -39
Remove Globe class defaulting to Earthmediawiki/extensions/GeoDatamaster+13 -13
Make BoundingBox store Coords instead of individual valuesmediawiki/extensions/GeoDatamaster+62 -50
Fix distance/distanceTo to work with globes other than Earthmediawiki/extensions/GeoDatamaster+27 -17
Fix Coord::bboxAround() not supporting non-Earth globesmediawiki/extensions/GeoDatamaster+21 -2
Customize query in gerrit

Event Timeline

MaxSem created this task.Mar 10 2017, 1:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2017, 1:21 AM
TheDJ subscribed.May 6 2024, 10:02 AM

Related https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GeoData/+/345602

Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 6 2024, 10:02 AM
Gehel triaged this task as Low priority.May 6 2024, 3:37 PM
Gehel moved this task from needs triage to Geodata on the Discovery-Search board.
thiemowmde added a project: User-thiemowmde.May 14 2024, 8:40 AM
thiemowmde subscribed.
gerritbot added a comment.May 14 2024, 7:39 PM

Change #1031548 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] [WIP] Change Math::distance to accept Coord instances

https://gerrit.wikimedia.org/r/1031548

gerritbot added a project: Patch-For-Review.May 14 2024, 7:39 PM
gerritbot added a comment.Jun 8 2024, 7:49 PM

Change #1040728 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] Fix Coord::bboxAround() not supporting non-Earth globes

https://gerrit.wikimedia.org/r/1040728

gerritbot added a comment.Jun 10 2024, 8:08 AM

Change #1040728 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Fix Coord::bboxAround() not supporting non-Earth globes

https://gerrit.wikimedia.org/r/1040728

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jun 10 2024, 9:00 AM
gerritbot added a comment.Aug 16 2024, 8:19 AM

Change #1031548 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Fix distance/distanceTo to work with globes other than Earth

https://gerrit.wikimedia.org/r/1031548

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2024, 8:30 AM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.19; 2024-08-20); removed MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Aug 16 2024, 9:00 AM
TheDJ closed this task as Resolved.Aug 16 2024, 9:52 AM
TheDJ assigned this task to thiemowmde.
thiemowmde reopened this task as Open.Aug 27 2024, 7:57 AM
gerritbot added a comment.Aug 27 2024, 7:58 AM

Change #1041047 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] Make BoundingBox store Coords instead of individual values

https://gerrit.wikimedia.org/r/1041047

gerritbot added a project: Patch-For-Review.Aug 27 2024, 7:58 AM
gerritbot added a comment.Sep 1 2024, 9:47 AM

Change #1041047 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Make BoundingBox store Coords instead of individual values

https://gerrit.wikimedia.org/r/1041047

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.21; 2024-09-03); removed MW-1.43-notes (1.43.0-wmf.19; 2024-08-20).Sep 1 2024, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 1 2024, 10:30 AM
gerritbot added a comment.Oct 1 2024, 11:21 AM

Change #1076994 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] Remove Globe class defaulting to Earth

https://gerrit.wikimedia.org/r/1076994

gerritbot added a project: Patch-For-Review.Oct 1 2024, 11:21 AM
gerritbot added a comment.Oct 19 2024, 12:59 PM

Change #1076994 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Remove Globe class defaulting to Earth

https://gerrit.wikimedia.org/r/1076994

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2024, 1:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.28; 2024-10-22); removed MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Oct 19 2024, 2:00 PM
thiemowmde removed thiemowmde as the assignee of this task.Dec 12 2024, 12:44 PM
gerritbot added a comment.Jan 28 2025, 5:38 PM

Change #1114786 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] Move misplaced bboxAround function into BoundingBox class

https://gerrit.wikimedia.org/r/1114786

gerritbot added a project: Patch-For-Review.Jan 28 2025, 5:38 PM

Change #1114787 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] [WIP] Accept Globe objects in more places

https://gerrit.wikimedia.org/r/1114787

gerritbot added a comment.Apr 20 2025, 7:34 PM

Change #1114786 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Move misplaced bboxAround function into BoundingBox class

https://gerrit.wikimedia.org/r/1114786

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Apr 20 2025, 8:00 PM
gerritbot added a comment.May 3 2025, 10:34 AM

Change #1114787 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Accept Globes as objects in many more places

https://gerrit.wikimedia.org/r/1114787

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.28; 2025-05-06); removed MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).May 3 2025, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 3 2025, 11:30 AM
thiemowmde added a project: Hackathon-Northwestern-Europe-2026.Mar 2 2026, 9:17 AM
gerritbot added a comment.Mar 2 2026, 10:27 AM

Change #1247017 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] Various code cleanups and modernizations

https://gerrit.wikimedia.org/r/1247017

gerritbot added a project: Patch-For-Review.Mar 2 2026, 10:27 AM
gerritbot added a comment.Mar 13 2026, 12:59 PM

Change #1251307 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] Allow the Moon as alternative globe in all APIs

https://gerrit.wikimedia.org/r/1251307

gerritbot added a comment.Mar 13 2026, 3:16 PM

Change #1247017 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Various code cleanups and modernizations

https://gerrit.wikimedia.org/r/1247017

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 13 2026, 4:00 PM
gerritbot added a comment.Mar 14 2026, 1:55 PM

Change #1251307 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Allow the Moon as alternative globe in all APIs

https://gerrit.wikimedia.org/r/1251307

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2026, 2:32 PM
gerritbot added a comment.Mar 14 2026, 8:42 PM

Change #1252072 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/GeoData@master] Add Mars and Venus as allowed globes

https://gerrit.wikimedia.org/r/1252072

gerritbot added a project: Patch-For-Review.Mar 14 2026, 8:42 PM
thiemowmde closed this task as Resolved.Mar 14 2026, 8:45 PM
thiemowmde claimed this task.
gerritbot added a comment.Mar 15 2026, 1:42 PM

Change #1252072 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Add Mars and Venus as allowed globes

https://gerrit.wikimedia.org/r/1252072

Maintenance_bot removed a project: Patch-For-Review.Mar 15 2026, 2:30 PM
thiemowmde moved this task from Proposed Projects to Ready for showcase on the Hackathon-Northwestern-Europe-2026 board.Mar 16 2026, 8:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits