+need-review

Note that this code is now in skins/common/edit.js (formerly wikibits.js).

Please provide an updated unified diff.

Created attachment 5187
Diff against -r39564

Uploaded new diff

attachment diff.39564 ignored as obsolete

Would someone please commit this patch? It is so small and useful, and it's been ready (and tested locally) for 9 months.

I will upload a new unified diff.

Created attachment 5853
Unified diff against trunk rev 47722

Attached:

Any chance this simple patch could see the light of day?
Thanks.

You may close this ticket. The "br" functionality can be implemented without a core code change, by overriding mwInsertEditButton in MediaWiki:common.js.

Solution:

var orig_mwInsertEditButton = window.mwInsertEditButton;
window.mwInsertEditButton = function(parent, item) {

if (item.imageFile == '<br>') {
   parent.appendChild(document.createElement("br"));
   return true;
}
return orig_mwInsertEditButton(parent, item);

}