Page MenuHomePhabricator

Notification controls spill over in RTL wikis
Closed, ResolvedPublic

Description

(highly likely this issue is dupe - could not find it, so i'm creating a new one. please close if it was reported).

Description:
"notifications" and "alerts" click-sensitive area spills over (to the right in ltr wikis, and to the left in RTL)

REPRODUCTION

  1. on a wiki of your choice, make sure both "alerts" and "notifications" are not empty (i.e., both show a number). hint - this can be easily accomplished by marking at least one notification and one alert as "not read".
  2. add "?uselang=fa" to the address line, to make it RTL
  3. click on the minivan icon, _outside_ the rectangle with the number

WHAT IS EXPECTED

the "notices" popup opens

WHAT ACTUALL HAPPENS

the "alerts" popup opens

REPRODUCTION #2
for this one, no RTL or preperation is required:

  1. on LTR wiki, gently float the mouse above the "Talk" menu item in the top menu
  2. notice the mouse cursor is "pointer", even when the "Talk" menu item is not underlined. there may or may not be "your notices" tooltip - could not figure it out - may be browser dependent: in ie i saw no tooltip, in chrome and FF i saw one. ( !important: you may have to gently move the mouse around to find this sweet spot. also notice that once the popup opens and closes, this sweet spot seems to evaporate. refresh to bring it back again...).
  3. click

EXPECTED

nothing should happen - you clicked on the screen outside of any link or control

ACTUAL

The "notices" popup opens.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Kipod updated the task description. (Show Details)

If it is, it should be 1) already fixed on hewiki and 2) fixed on fawiki in ~24h.

This comment was removed by YonaB.

It in still not fix on hewiki.

Looks like that deployment was rolled back. When https://tools.wmflabs.org/versions/ says group1 has wmf.18, it'll be fixed on hewiki. That was supposed to happen yesterday but it didn't.

Checked the both scenarios in hewiki (and ptwiki) with wmf.18 (on Chrome and IE11). It seems that the fix from T161302: Invisible link to notifications can overlap link to personal talk page is in place.

Etonkovidova triaged this task as Medium priority.