RC filters - 'No Filters found' produces 'TypeError: undefined is not an object (evaluating 'filterItem.isSelected')'
Closed, ResolvedPublic
Actions

Description

In betalabs (also found on plwiki wmf.19) on RC page in 'Search filter area' enter search criteria that return 'No Filters found'. That will display 'TypeError: undefined is not an object (evaluating 'filterItem.isSelected')' in the Console.

Uncaught TypeError: Cannot read property 'isSelected' of undefined
    at MwRcfiltersController.mw.rcfilters.Controller.toggleFilterSelect (eval at <anonymous>
    at MwRcfiltersUiFilterWrapperWidget.mw.rcfilters.ui.FilterWrapperWidget.onTextInputEnter 
    at OoUiTextInputWidget.oo.EventEmitter.emit (eval at <anonymous> 
    at OoUiTextInputWidget.OO.ui.TextInputWidget.onKeyPress 
    at HTMLInputElement.dispatch
    at HTMLInputElement.elemData.handle

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters UI: Check that filter exists before changing its state	mediawiki/core	master	+8 -1

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Apr 6 2017, 11:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2017, 11:03 PM

Etonkovidova renamed this task from RC filters - ' to RC filters - 'No Filters found' produces 'TypeError: undefined is not an object (evaluating 'filterItem.isSelected')'.Apr 6 2017, 11:10 PM

Etonkovidova added projects: Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).

Etonkovidova updated the task description. (Show Details)

Change 347035 had a related patch set uploaded (by Mooeypoo):
[mediawiki/core@master] RCFilters UI: Check that filter exists before changing its state

https://gerrit.wikimedia.org/r/347035

gerritbot added a project: Patch-For-Review.Apr 7 2017, 6:16 PM

Mooeypoo claimed this task.Apr 7 2017, 6:16 PM

Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 7 2017, 6:30 PM

Change 347035 merged by jenkins-bot:
[mediawiki/core@master] RCFilters UI: Check that filter exists before changing its state

https://gerrit.wikimedia.org/r/347035

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)).Apr 7 2017, 7:00 PM