[Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Apr 10 2017, 5:54 PM

Description

Steps to reproduce:

Open VE
Make some edit
Switch to NWE
Switch back to VE
Go to visual diff section

There is an error appearing in the console:

Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined

at Array.forEach (native)
at VeUiDiffElement.ve.ui.DiffElement.positionDescriptions

Screen Shot 2017-04-10 at 10.52.03 AM.png (691×1 px, 256 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (e4540d87f)	mediawiki/extensions/VisualEditor	master	+1 -1
	VisualDiff: Ignore un-rendered modified elements	VisualEditor/VisualEditor	master	+7 -2

Customize query in gerrit

Related Objects

Mentioned Here: rGVEDe4540d87f8d6: Merge "Update OOjs UI to v0.21.0"

Event Timeline

Ryasmeen created this task.Apr 10 2017, 5:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2017, 5:54 PM

• Oude--ewe subscribed.Apr 10 2017, 6:05 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Apr 10 2017, 6:07 PM

Change 347449 had a related patch set uploaded (by Esanders):
[VisualEditor/VisualEditor@master] VisualDiff: Ignore un-rendered modified elements

https://gerrit.wikimedia.org/r/347449

gerritbot added a project: Patch-For-Review.Apr 10 2017, 8:18 PM

Change 347449 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] VisualDiff: Ignore un-rendered modified elements

https://gerrit.wikimedia.org/r/347449

Ryasmeen renamed this task from Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch to [Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch.Apr 10 2017, 10:06 PM

Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 10:55 PM

Change 348008 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e4540d87f)

https://gerrit.wikimedia.org/r/348008

Change 348008 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e4540d87f)

https://gerrit.wikimedia.org/r/348008

Jdforrester-WMF closed this task as Resolved.Apr 13 2017, 3:59 AM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF set the point value for this task to 1.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 13 2017, 3:59 AM

Jdforrester-WMF removed a project: Patch-For-Review.Apr 13 2017, 3:59 AM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 13 2017, 4:00 AM

Ryasmeen added a project: Verified.Apr 25 2017, 7:51 PM

Ryasmeen added a project: Verified-in-Phase0.Apr 26 2017, 8:17 PM

	F7462385: Screen Shot 2017-04-10 at 10.52.03 AM.png
	Apr 10 2017, 5:54 PM

[Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switchClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch
Closed, ResolvedPublic1 Estimated Story Points
Actions