Page MenuHomePhabricator

[Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Open VE
  2. Make some edit
  3. Switch to NWE
  4. Switch back to VE
  5. Go to visual diff section

There is an error appearing in the console:

Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined

at Array.forEach (native)
at VeUiDiffElement.ve.ui.DiffElement.positionDescriptions

Event Timeline

Ryasmeen created this task.Apr 10 2017, 5:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2017, 5:54 PM

Change 347449 had a related patch set uploaded (by Esanders):
[VisualEditor/VisualEditor@master] VisualDiff: Ignore un-rendered modified elements

https://gerrit.wikimedia.org/r/347449

Change 347449 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] VisualDiff: Ignore un-rendered modified elements

https://gerrit.wikimedia.org/r/347449

Ryasmeen renamed this task from Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch to [Regression pre-wmf.20] Error "Cannot read property 'getBoundingClientRect' of undefined" while trying to open visual diff after switch.Apr 10 2017, 10:06 PM

Change 348008 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e4540d87f)

https://gerrit.wikimedia.org/r/348008

Change 348008 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e4540d87f)

https://gerrit.wikimedia.org/r/348008

Jdforrester-WMF closed this task as Resolved.Apr 13 2017, 3:59 AM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 13 2017, 3:59 AM