[Regression pre-wmf.20] Error "Uncaught TypeError: Cannot read property 'positionDescriptions' of null" after saving page from visual diff
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Apr 10 2017, 10:04 PM

Description

Steps to reproduce:

Edit a page
Go to visual diff section
Click on Save Changes

The following error appears in the console:
Uncaught TypeError: Cannot read property 'positionDescriptions' of null

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	MWSaveDialog: Check diffElement still exists after setTimeout	mediawiki/extensions/VisualEditor	master	+5 -3

Customize query in gerrit

Event Timeline

Ryasmeen created this task.Apr 10 2017, 10:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2017, 10:04 PM

Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 10:55 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Apr 10 2017, 11:01 PM

I don't get this – is there a particular edit/page that it happens on for you?

It's happening on all pages for me.
Here is a screen capture if it helps,

Error .mov1 MBDownload

Jdforrester-WMF triaged this task as Medium priority.Apr 17 2017, 6:06 PM

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF added a subscriber: Esanders.

Change 349892 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Check diffElement still exists after setTimeout

https://gerrit.wikimedia.org/r/349892

gerritbot added a project: Patch-For-Review.Apr 24 2017, 6:03 PM

Jdforrester-WMF closed this task as Resolved.Apr 24 2017, 6:04 PM

Jdforrester-WMF assigned this task to Esanders.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 24 2017, 6:04 PM

Change 349892 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Check diffElement still exists after setTimeout

https://gerrit.wikimedia.org/r/349892

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 24 2017, 7:00 PM

Ryasmeen edited projects, added Verified; removed Patch-For-Review.Apr 24 2017, 9:04 PM

Ryasmeen added a project: Verified-in-Phase0.Apr 26 2017, 8:16 PM

	F7472923: Error .mov
	Apr 10 2017, 11:25 PM

[Regression pre-wmf.20] Error "Uncaught TypeError: Cannot read property 'positionDescriptions' of null" after saving page from visual diff Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

[Regression pre-wmf.20] Error "Uncaught TypeError: Cannot read property 'positionDescriptions' of null" after saving page from visual diff
Closed, ResolvedPublic1 Estimated Story Points
Actions