Page MenuHomePhabricator
Create Task
Maniphest T162653

Refreshed should use core-provided tablet width variable
Closed, DeclinedPublic
Actions

Description

See more on https://gerrit.wikimedia.org/r/#/c/260517/ as well as T140804. The variable provided seems to be @deviceWidthTablet

Related Objects

Event Timeline

SamanthaNguyen created this task.Apr 11 2017, 4:14 AM
SamanthaNguyen moved this task from Backlog to Feedback on the Refreshed board.Apr 13 2017, 12:15 AM
MtMNC subscribed.Jan 8 2019, 2:17 AM

The variable listed is now deprecated. Regardless, I think we should choose the breakpoints between Refreshed's views ourselves, since we can fine tune the skin better if we have that freedom. I do agree the current small/medium breakpoint is too small though.

MtMNC mentioned this in T200303: Refreshed skin v4.Jan 8 2019, 2:18 AM
georgebarnick subscribed.Jan 8 2019, 2:40 AM
MtMNC closed this task as Declined.Jan 11 2019, 6:10 PM

Marking as declined since we're not using the variable. The breakpoint between small and medium was adjusted in 488f4149ab7a.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL