Page MenuHomePhabricator
Create Task
Maniphest T162775

Review publish vs save wording in TwoColumnConflict extension
Closed, ResolvedPublic
Actions

Description

Some newer changes done in the did not consider the setting there. We should review the whole wording implement switches to match the Wiki's setting.

The config var to look for is wgEditSubmitButtonLabelPublish if this is set to true it should say publish if not it should say save.

Details

SubjectRepoBranchLines +/-
Reuse i18n messages and use right submit labelmediawiki/extensions/TwoColConflictmaster+35 -22
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Apr 12 2017, 8:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2017, 8:23 AM
Tobi_WMDE_SW moved this task from Incoming to Edit Conflict Handling on the TCB-Team (now WMDE-TechWish) board.Apr 25 2017, 10:14 AM
Tobi_WMDE_SW moved this task from Proposed to Todo on the WMDE-TechWish board.May 2 2017, 3:20 PM
WMDE-Fisch claimed this task.May 3 2017, 10:05 AM
WMDE-Fisch moved this task from Todo to Sprint ready on the WMDE-TechWish board.
gerritbot subscribed.May 3 2017, 11:46 AM

Change 351624 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Reuse i18n messages and use right submit label

https://gerrit.wikimedia.org/r/351624

gerritbot added a project: Patch-For-Review.May 3 2017, 11:46 AM
WMDE-Fisch mentioned this in rESCC7e3c6fa62fb2: Reuse i18n messages and use right submit label.May 3 2017, 11:46 AM
WMDE-Fisch moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.May 3 2017, 12:01 PM
WMDE-Fisch mentioned this in rESCCe8aeb9451835: Reuse i18n messages and use right submit label.May 9 2017, 10:54 AM
WMDE-Fisch mentioned this in rESCC1db868306085: Reuse i18n messages and use right submit label.May 19 2017, 12:33 PM
WMDE-Fisch mentioned this in rESCC614ec69d58ed: Reuse i18n messages and use right submit label.Jun 1 2017, 7:27 AM
WMDE-Fisch mentioned this in rESCC7c93f908cf81: Reuse i18n messages and use right submit label.Jun 1 2017, 4:14 PM
• Lea_WMDE moved this task from Backlog to Maintenance (current beta feature) on the Two-Column-Edit-Conflict-Merge board.Jun 2 2017, 1:58 PM
WMDE-Fisch mentioned this in rESCCeb66f3b7cd7b: Reuse i18n messages and use right submit label.Jun 6 2017, 12:17 PM
gerritbot added a comment.Jun 8 2017, 10:35 AM

Change 351624 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Reuse i18n messages and use right submit label

https://gerrit.wikimedia.org/r/351624

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 8 2017, 11:00 AM
WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.Jun 13 2017, 11:33 AM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jun 20 2017, 2:25 PM
Tobi_WMDE_SW closed this task as Resolved.Jun 20 2017, 2:32 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits